[education/labplot] src/frontend/script: Minor cleanup.
Alexander Semke <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit d2673f041dfdc38a3dd2c2eb24b69eaa57658a65 by Alexander Semke.
Committed on 01/08/2026 at 20:22.
Pushed by asemke into branch 'master'.
Minor cleanup.
M +5 -7 src/frontend/script/ScriptCompletionModel.cpp
M +0 -14 src/frontend/script/ScriptEditor.cpp
https://invent.kde.org/education/labplot/-/commit/d2673f041dfdc38a3dd2c2eb24b69eaa57658a65
diff --git a/src/frontend/script/ScriptCompletionModel.cpp b/src/frontend/script/ScriptCompletionModel.cpp
index 78cbd28a9b..8b6768292b 100644
--- a/src/frontend/script/ScriptCompletionModel.cpp
+++ b/src/frontend/script/ScriptCompletionModel.cpp
@@ -17,9 +17,7 @@
#include <KTextEditor/Document>
#include <QTimer>
-#include <QSet>
#include <QRegularExpression>
-#include <algorithm>
ScriptCompletionModel::ScriptCompletionModel(ScriptEditor* parent)
: KTextEditor::CodeCompletionModel(parent)
@@ -111,7 +109,7 @@ void ScriptCompletionModel::updateUserVariables(const QString& scriptText) {
static QRegularExpression assignPattern(QStringLiteral(R"(^(\w+)\s*=)"), QRegularExpression::MultilineOption);
QSet<QString> variables;
- QRegularExpressionMatchIterator it = assignPattern.globalMatch(scriptText);
+ auto it = assignPattern.globalMatch(scriptText);
while (it.hasNext()) {
QRegularExpressionMatch match = it.next();
@@ -232,7 +230,7 @@ QVariant ScriptCompletionModel::data(const QModelIndex& index, int role) const {
if (!index.isValid() || index.row() >= m_matches.count())
return QVariant();
- const CompletionItem& item = m_matches.at(index.row());
+ const auto& item = m_matches.at(index.row());
switch (role) {
case Qt::DisplayRole:
@@ -258,11 +256,11 @@ QVariant ScriptCompletionModel::data(const QModelIndex& index, int role) const {
return QVariant();
}
-void ScriptCompletionModel::executeCompletionItem(KTextEditor::View* view, const KTextEditor::Range& word, const QModelIndex& index) const {
+void ScriptCompletionModel::executeCompletionItem(KTextEditor::View* view, const KTextEditor::Range& /* word */, const QModelIndex& index) const {
if (!index.isValid() || !view)
return;
- const CompletionItem& item = m_matches.at(index.row());
+ const auto& item = m_matches.at(index.row());
QString textToInsert = item.name;
// Add parentheses for functions and classes
@@ -360,7 +358,7 @@ QList<ScriptCompletionModel::CompletionItem> ScriptCompletionModel::getMembersFo
return m_memberCache[typeName];
// Use runtime introspection to get real class members from Python
- QList<PylabplotMemberInfo> pylabplotMembers = getPylabplotClassMembersHelper(typeName);
+ auto pylabplotMembers = getPylabplotClassMembersHelper(typeName);
// Convert to CompletionItem format
for (const auto& memberInfo : pylabplotMembers) {
diff --git a/src/frontend/script/ScriptEditor.cpp b/src/frontend/script/ScriptEditor.cpp
index 691561472a..74a0988cde 100644
--- a/src/frontend/script/ScriptEditor.cpp
+++ b/src/frontend/script/ScriptEditor.cpp
@@ -19,22 +19,8 @@
#include <KConfig>
#include <KConfigGroup>
-#include <QPushButton>
-#include <QHBoxLayout>
#include <QMenu>
-#include <QAction>
-#include <QToolBar>
-#include <QString>
-#include <QToolButton>
-#include <QVariant>
-#include <QFont>
-#include <QObject>
-#include <QTextBrowser>
-#include <QRegularExpression>
-#include <QTextCursor>
-#include <QTextCharFormat>
#include <QClipboard>
-#include <QApplication>
ScriptEditor::ScriptEditor(Script* script, QWidget* parent)
: QWidget(parent), m_script(script) {