[qt/qt/qtbase]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt/qtbase Pushed by mirror-service into branch 'dev'. Changed from 3e81bed3317531e3e47bed5dc8a385223c3cae1e to b071724f93d23a242323dc02cb5f917c962f6056 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit dc8986850bd16815abf28b6d07b3688f3709ba4f by Liang Qi (on behalf of Zbigniew Chyla) on 02/08/2026 at 13:08.. ohos: Extras: return native ids as qint64, not double tryGetNativeWindowId() and tryGetScreenDisplayId() returned std::optional<double>. The values are read through the ETS/JS API, where every number is a double, which is how they surfaced as double in the external API - but the ids are integral, so double is a surprising and lossy-looking type for them. The native SDK confirms the ids are integral, but with no single canonical type: window id is int32_t in the window manager (oh_window.h) yet uint32_t/uint64_t in the PiP and vsync APIs, display id is int32_t in start_options, int64_t in OH_WindowManager_GetAllWindowLayoutInfoList(), and uint32_t/uint64_t in the display manager. Because the native types are mixed in both width and signedness, use qint64: it is signed (matching Qt convention and QAndroidScreen::displayId()) and wide enough to hold every native form without narrowing. Use the existing convertDoubleTo() helper to validate the value first and warn instead of returning a invalid id. Convert at the boundary, private interfaces still deal in double. Task-number: QTBUG-147194 Pick-to: 6.12 Change-Id: I69690bbcdf87644ff09a9fb3852a9ca920ac4bbc Reviewed-by: Liang Qi <[email protected]> Reviewed-by: Marc Mutz <[email protected]> https://invent.kde.org/qt/qt/qtbase/-/commit/dc8986850bd16815abf28b6d07b3688f3709ba4f Git commit b3554d9320b23e0632ef6aab634cabc9a6069002 by Liang Qi (on behalf of Zbigniew Chyla) on 02/08/2026 at 13:08.. ohos: Extras: return AbilityContext instances by raw pointer defaultInstance() and instanceForMainWindow() returned shared_ptr, inconsistent with AppContext::instance() (raw) and unnecessary: these objects are owned by QtHarmonyExtras (a process-lifetime singleton and a per-window map keyed on the QWindow), never by the caller. Handing out a shared_ptr let a caller keep a per-window context alive past its window, turning it into a zombie that still fires newWantInfoReceived. Return raw non-owning pointers, matching AppContext::instance() and the Qt idiom for framework-owned QObjects. The per-window map now holds unique_ptr to make sole ownership explicit. Task-number: QTBUG-147194 Pick-to: 6.12 Change-Id: Ic0bb67ea54068bf6bcfe9631c9eb581a7aee7abb Reviewed-by: Liang Qi <[email protected]> Reviewed-by: Marc Mutz <[email protected]> https://invent.kde.org/qt/qt/qtbase/-/commit/b3554d9320b23e0632ef6aab634cabc9a6069002 Git commit 970b6ece6a77d14821fbf200e6d381ac13d34a06 by Liang Qi (on behalf of Zbigniew Chyla) on 02/08/2026 at 13:08.. ohos: Extras: normalize include order and style module-wide The module's include blocks were neither consistently grouped nor sorted, and pulled in foreign same-module headers with double quotes instead of the <QtHarmonyExtras/private/...> form. Reorder them per the "Includes" section of the Qt review guidelines: group by descending specificity - this module's headers, then dependent Qt modules, then QtCore, then C++, then platform/3rd-party - separated by blank lines, private Qt headers after public within each module, and alphabetical within each group. Use angle brackets for foreign same-module headers, keeping double quotes only for each .cpp's own header. See https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Includes No functional change. Task-number: QTBUG-147194 Pick-to: 6.12 Change-Id: I7aa1d70c050dc200474c0dae5f432f4fc52b30bb Reviewed-by: Liang Qi <[email protected]> https://invent.kde.org/qt/qt/qtbase/-/commit/970b6ece6a77d14821fbf200e6d381ac13d34a06 Git commit b071724f93d23a242323dc02cb5f917c962f6056 by Liang Qi (on behalf of Zbigniew Chyla) on 02/08/2026 at 13:08.. ohos: Extras: drop redundant <utility> includes Seven files include <utility> explicitly, even though every Qt header pulls in qcompilerdetection.h, which is guaranteed to include it. The Qt review guidelines list <utility> among the headers that must not be included again. Remove those includes. See https://wiki.qt.io/Things_To_Look_Out_For_In_Reviews#Includes No functional change. Task-number: QTBUG-147194 Pick-to: 6.12 Change-Id: I67922131b88088cc04e89b24b2a5f5342879c458 Reviewed-by: SanthoshKumar Selvaraj <[email protected]> https://invent.kde.org/qt/qt/qtbase/-/commit/b071724f93d23a242323dc02cb5f917c962f6056