[pim/trojita] src/qwwsmtpclient: Avoid unnecessary QString memory allocation

Espen Sandøy Hustad <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit 8b6697cf8086e109e847917aecdb9c3c9f63a985 by Espen Sandøy Hustad.
Committed on 03/08/2026 at 19:01.
Pushed by ehustad into branch 'master'.

Avoid unnecessary QString memory allocation

Fix Clazy warning: unneeded allocation
[-Wclazy-qstring-insensitive-allocation]

M  +1    -1    src/qwwsmtpclient/qwwsmtpclient.cpp

https://invent.kde.org/pim/trojita/-/commit/8b6697cf8086e109e847917aecdb9c3c9f63a985

diff --git a/src/qwwsmtpclient/qwwsmtpclient.cpp b/src/qwwsmtpclient/qwwsmtpclient.cpp
index da348d4f8..8695218b8 100644
--- a/src/qwwsmtpclient/qwwsmtpclient.cpp
+++ b/src/qwwsmtpclient/qwwsmtpclient.cpp
@@ -558,7 +558,7 @@ void QwwSmtpClientPrivate::parseOption(const QString &buffer){
     if(buffer.toLower()=="pipelining"){                     options |= QwwSmtpClient::PipeliningOption;     }
     else if(buffer.toLower()=="starttls"){                  options |= QwwSmtpClient::StartTlsOption;       }
     else if(buffer.toLower()=="8bitmime"){                  options |= QwwSmtpClient::EightBitMimeOption;   }
-    else if(buffer.toLower().startsWith("auth ")){          options |= QwwSmtpClient::AuthOption;
+    else if(buffer.startsWith("auth ", Qt::CaseInsensitive)){          options |= QwwSmtpClient::AuthOption;
         // parse auth modes
         QStringList slist = buffer.mid(5).split(" ");
         foreach(const QString &s, slist){
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.