[qt/qtqa/gerrit]: Summary of bulk changes made

KDE Git Services - Bulk Change <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git repository change summary for qt/qtqa/gerrit
Pushed by mirror-service into branch 'upstream/master'.
Changed from 017823543c322cd1b3500bdc91d8b5a62baf5caf to b2990669a9c005d79e6b722df0b595e4d68678bc
Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository.

This change contains the following new commits:

Git commit 8d3319bc9055f0a91505b9495c97fc5cef848fd5 by Becky Siegel on 05/08/2026 at 00:50..
Fix Java style and clarity lint findings

- Name acronyms as words in setAllowDowngradeToCc
- Use pattern-matching instanceof in ReviewerModifier
- Catch RuntimeException in WorkQueue#toString
- Import classes in ProjectWatchIT instead of fully qualifying
- Standardize parameter comments in MigrateLabelFunctionsToSubmitRequirementIT

Google-Bug-Id: b/542757056
Release-Notes: none
Change-Id: Ied60ddc580441e9f5247121f8fb0994aa8f0ba74
https://invent.kde.org/qt/qtqa/gerrit/-/commit/8d3319bc9055f0a91505b9495c97fc5cef848fd5

Git commit 6a7da79d80bd2a7c52d1b31bc5213b71c1e327cf by David Ostrovsky on 05/08/2026 at 13:01..
Demote NullArgumentForNonNullParameter to a warning

Since the rules_java 9.3.0 -> 9.5.0 bump in commit f999479bed, the Java
21 CI verification fails on about twenty call sites that pass a null
default value to Guava methods such as Iterables.getFirst(). The code is
correct: null is the documented default-value usage, and getFirst() is
declared <T extends @Nullable Object>, so its @ParametricNullness
defaultValue parameter accepts null whenever the inferred type argument
is nullable.

The errors are a known Error Prone false positive [1] that only occurs
when javac fails to read the @Nullable type-use annotation on the
type-variable bound from the Guava class files. Reading such annotations
from class files was fixed by JDK-8341779 [2], a redo of the earlier
JDK-8225377 [3], and needs a JDK 21 update release that includes the
backport (21.0.8 or later). Error Prone started trusting these bound
annotations in [4], which shipped with the newer Error Prone bundled by
rules_java 9.5.0.

Bazel's remotejdk_21 is Azul Zulu 21.0.9+10, which does not contain the
JDK-8341779 backport; vendor discretion over backports is called out by
the Error Prone maintainers in [1], and Temurin 21.0.9+10 does contain
it. This is why the check misfires only in the Java 21 verification:
with the Java 25 toolchain javac reads the annotation correctly and the
check stays silent, as it should.

Demote the check to a warning instead of disabling it, so the signal
stays visible in build logs on both toolchains without failing the Java
21 CI. Restore it to an error once Bazel's remotejdk_21 points at a JDK
21 update with the JDK-8341779 backport; Zulu 21.0.11 and 21.0.12 are
already published, but even rules_java 9.7.0 still pins Zulu 21.0.9
[5]; a repin has been requested upstream [6].

[1] https://github.com/google/error-prone/issues/5436
[2] https://bugs.openjdk.org/browse/JDK-8341779
[3] https://bugs.openjdk.org/browse/JDK-8225377
[4] https://github.com/google/error-prone/pull/5429
[5] https://github.com/bazelbuild/rules_java/releases/tag/9.7.0
[6] https://github.com/bazelbuild/rules_java/issues/369

Release-Notes: skip
Change-Id: Ib59e2c8f04a7d1365e9b2a84c7f01d3e58a6b9c2
https://invent.kde.org/qt/qtqa/gerrit/-/commit/6a7da79d80bd2a7c52d1b31bc5213b71c1e327cf

Git commit b2990669a9c005d79e6b722df0b595e4d68678bc by Gerrit Code Review (on behalf of David Ostrovsky) on 05/08/2026 at 18:00..
Merge "Demote NullArgumentForNonNullParameter to a warning"
https://invent.kde.org/qt/qtqa/gerrit/-/commit/b2990669a9c005d79e6b722df0b595e4d68678bc
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.