[qt/qt/qtlanguageserver]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt/qtlanguageserver Pushed by mirror-service into branch '6.12'. Changed from b2f61ab117915052d6729ba3cf82899a16bf2d62 to c7656cbde30d505ebb91254eb08a85433d026d72 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit 265edbce2c73ef4b2786c337875537040a82752a by Qt Cherry-pick Bot (on behalf of Semih Yavuz) on 06/08/2026 at 10:40.. qtlanguageserver: avoid potential double-free or use-after-free RequestBatchHandler::processMessages() incremented a pending-request counter and deleted itself once the counter reached zero. A handler that resolves syncronously could hit delete to fire before dispatching had actually finished. This could either lead to double-free or use-after-free depending on the size of the batch. Add a "dispatch done" guard so the object is only deleted once, and only after the dispatch loop has fully completed. Fixes: QTBUG-148484 Change-Id: I2a4ffa488619feb84595d74bf76be408fc32dd18 Reviewed-by: Sami Shalayel <[email protected]> Reviewed-by: Olivier De Cannière <[email protected]> (cherry picked from commit e5f8ae5ff8f71235ffefb0ffe2e5d02f4ac1001e) Reviewed-by: Qt Cherry-pick Bot <[email protected]> https://invent.kde.org/qt/qt/qtlanguageserver/-/commit/265edbce2c73ef4b2786c337875537040a82752a Git commit c7656cbde30d505ebb91254eb08a85433d026d72 by Qt Cherry-pick Bot (on behalf of Semih Yavuz) on 06/08/2026 at 10:40.. qjsonrpc: remove dead duplicate-id scan from batch completion RequestBatchHandler's completion lambda appended the finished response to m_finished and then scanned the entire list looking for an entry matching the id it had just completed, falling back to an "internal error" response if no match was found. That entry is always the one appended one line earlier in the same lambda invocation, so the scan could never fail to find it which makes the "not found" branch was unreachable. Remove the scan and its dead branch; this has no effect on behavior. Fixes: QTBUG-148493 Change-Id: If87018b022154201c706c71fa4e75ceb80c720e0 Reviewed-by: Sami Shalayel <[email protected]> (cherry picked from commit 891ee11ead633ee7cffee6673b46ea022eaa6e6e) Reviewed-by: Qt Cherry-pick Bot <[email protected]> https://invent.kde.org/qt/qt/qtlanguageserver/-/commit/c7656cbde30d505ebb91254eb08a85433d026d72