[qt/qt/qtquick3d]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qt/qtquick3d Pushed by mirror-service into branch 'dev'. Changed from be1755f012877a743cde18a63906ccf08791290a to 62116be041a3f744ec7fb951599c392d45cbdf82 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit c9acf91973b86c1f956dfabd20ccaa09a24c23bc by Andy Nichols on 07/08/2026 at 09:09.. Doc: Mark QQuick3DLightmapBaker member documentation as internal QDoc reports "Cannot tie this documentation to anything" for the comments preceding QQuick3DLightmapBaker::bake(Callback) and QQuick3DLightmapBaker::denoise(Callback). Task-number: QTBUG-148806 Pick-to: 6.12 6.11 6.8 Change-Id: I079c63e1cc9c0eac0c71b62f5bb278d736c3e0a3 Reviewed-by: Jonas Karlsson <[email protected]> https://invent.kde.org/qt/qt/qtquick3d/-/commit/c9acf91973b86c1f956dfabd20ccaa09a24c23bc Git commit 62116be041a3f744ec7fb951599c392d45cbdf82 by Andy Nichols on 07/08/2026 at 09:10.. Fix out-of-bounds access when culling depth sorted LOD instances The depth sorted call site passed a byte count where cullLodInstances() expects a number of QSSGRenderInstanceTableEntry, so the loop ran 80 times too many iterations, reading past the end of the source buffer and writing past the end of the destination. Plain QML is enough to trigger it, and the corruption is severe enough to crash. Convert both helpers to take spans of entries, so the byte count to entry count conversion happens in one place and the call sites cannot disagree about which of the two they pass. The conversion clamps to what the buffer can hold, which also covers sortInstances(), where nothing guaranteed that the advertised instance count fit in the table data. The two LOD call sites are now identical and merged, and the stride assertion moves to prepareInstancing() so it covers culling as well. The new autotest renders instances at three known distances with various thresholds and verifies that exactly the ones within them are drawn. Without this fix the depth sorted rows abort the test. The test is blacklisted on Android, where the emulator's GLES translator refuses the instanced vertex attribute arrays of the LOD culled draws and keeps its previous attribute state instead, putting the instances somewhere other than where the thresholds asked for. The rows without culling render correctly there, so the culling itself is fine. Fixes: QTBUG-148789 Pick-to: 6.12 6.11 6.8 Change-Id: I5bfebbac32ac5f6b0c79c5f1035cbd54d3f4ed86 Reviewed-by: Christian Strømme <[email protected]> https://invent.kde.org/qt/qt/qtquick3d/-/commit/62116be041a3f744ec7fb951599c392d45cbdf82