[pim/trojita] src/Imap/Model: Add missing NOTIFY to Q_PROPERTY
Espen Sandøy Hustad <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit 53e4105c41f0a6c145066d39da94b61fd2e76920 by Espen Sandøy Hustad.
Committed on 09/08/2026 at 08:37.
Pushed by ehustad into branch 'master'.
Add missing NOTIFY to Q_PROPERTY
Fix Clazy warning: Q_PROPERTY should have either NOTIFY or
CONSTANT [-Wclazy-property-without-notify]
M +10 -0 src/Imap/Model/Model.cpp
M +6 -2 src/Imap/Model/Model.h
https://invent.kde.org/pim/trojita/-/commit/53e4105c41f0a6c145066d39da94b61fd2e76920
diff --git a/src/Imap/Model/Model.cpp b/src/Imap/Model/Model.cpp
index 58f40fa93..aa2d7c273 100644
--- a/src/Imap/Model/Model.cpp
+++ b/src/Imap/Model/Model.cpp
@@ -1823,7 +1823,12 @@ QStringList Model::normalizeFlags(const QStringList &source) const
/** @short Set the IMAP username */
void Model::setImapUser(const QString &imapUser)
{
+ if (m_imapUser == imapUser) {
+ return;
+ }
+
m_imapUser = imapUser;
+ emit imapUserChanged();
}
/** @short Username to use for login */
@@ -1835,9 +1840,14 @@ QString Model::imapUser() const
/** @short Set the password that the user wants to use */
void Model::setImapPassword(const QString &password)
{
+ if (m_imapPassword == password) {
+ return;
+ }
+
m_imapPassword = password;
m_hasImapPassword = PasswordAvailability::AVAILABLE;
informTasksAboutNewPassword();
+ emit imapPasswordChanged();
}
/** @short Return the user's password, if cached */
diff --git a/src/Imap/Model/Model.h b/src/Imap/Model/Model.h
index 7d5ad9390..f6b6ea2d5 100644
--- a/src/Imap/Model/Model.h
+++ b/src/Imap/Model/Model.h
@@ -95,8 +95,8 @@ class Model: public QAbstractItemModel
{
Q_OBJECT
- Q_PROPERTY(QString imapUser READ imapUser WRITE setImapUser)
- Q_PROPERTY(QString imapPassword READ imapPassword WRITE setImapPassword RESET unsetImapPassword)
+ Q_PROPERTY(QString imapUser READ imapUser WRITE setImapUser NOTIFY imapUserChanged)
+ Q_PROPERTY(QString imapPassword READ imapPassword WRITE setImapPassword RESET unsetImapPassword NOTIFY imapPasswordChanged)
Q_PROPERTY(QString imapAuthError READ imapAuthError NOTIFY imapAuthErrorChanged)
Q_PROPERTY(bool isNetworkAvailable READ isNetworkAvailable NOTIFY networkPolicyChanged)
Q_PROPERTY(bool isNetworkOnline READ isNetworkOnline NOTIFY networkPolicyChanged)
@@ -423,6 +423,10 @@ signals:
void imapAuthErrorChanged(const QString &error);
+ void imapUserChanged();
+
+ void imapPasswordChanged();
+
private:
Model &operator=(const Model &); // don't implement
Model(const Model &); // don't implement