[qt/qtqa/gerrit]: Summary of bulk changes made

KDE Git Services - Bulk Change <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git repository change summary for qt/qtqa/gerrit
Pushed by mirror-service into branch 'upstream/stable-3.13'.
Changed from 5705205e6c1c38f3c424dc5fdec4d07849854870 to 535b918d6716917a6d29067fb2923f976e30f93d
Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository.

This change contains the following new commits:

Git commit 535b918d6716917a6d29067fb2923f976e30f93d by Orgad Shaneh on 10/08/2026 at 04:45..
Fix NPE in ReplaceOp#postUpdate when the change is closed

ReplaceOp#updateChange returns early, without creating a new patch set,
when the change turns out to be closed, e.g. because it got submitted or
abandoned concurrently. BatchUpdate#executePostOps still invokes
postUpdate for every op, regardless of what updateChange returned, so
postUpdate then dereferences fields that were never assigned:

  java.lang.NullPointerException: Cannot invoke
  "...ReviewerModifier$ReviewerModificationList.postUpdate(...)"
  because "this.reviewerAdditions" is null
    at com.google.gerrit.server.git.receive.ReplaceOp.postUpdate
    at com.google.gerrit.server.update.BatchUpdate.executePostOps

The NullPointerException replaces the rejection reason, so the pushing
user gets an internal server error instead of being told that the change
is closed.

Skip postUpdate when a rejection reason was recorded, which is exactly
the case in which updateChange bailed out. The wrapped MergedByPushOp is
not notified either, as its updateChange was not called in that case.

Release-Notes: Fix NPE when pushing a new patch set to a change that got closed concurrently
Change-Id: I929730f825c2a184c16e94eb30621549e9059dff
https://invent.kde.org/qt/qtqa/gerrit/-/commit/535b918d6716917a6d29067fb2923f976e30f93d
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.