[graphics/krita] libs/ui/tool: Fix safe assert when strokeId not available

Emmet O'Neill <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit 6f05bb554b65bcfc72684bd19f330236f3d0c35c by Emmet O'Neill, on behalf of Dat Le.
Committed on 13/08/2026 at 23:16.
Pushed by emmetoneill into branch 'master'.

Fix safe assert when strokeId not available

M  +4    -1    libs/ui/tool/KisAsyncColorSamplerHelper.cpp

https://invent.kde.org/graphics/krita/-/commit/6f05bb554b65bcfc72684bd19f330236f3d0c35c

diff --git a/libs/ui/tool/KisAsyncColorSamplerHelper.cpp b/libs/ui/tool/KisAsyncColorSamplerHelper.cpp
index 7beb9bcd046..0648ebb949c 100644
--- a/libs/ui/tool/KisAsyncColorSamplerHelper.cpp
+++ b/libs/ui/tool/KisAsyncColorSamplerHelper.cpp
@@ -466,7 +466,7 @@ QRectF KisAsyncColorSamplerHelper::colorPreviewDocRect(const QPointF &docPoint)
     m_d->style = cfg.colorSamplerPreviewStyle();
     QRectF previewDocRect = m_d->colorPreviewDocRect(docPoint);
 
-    if (previewDocRect != m_d->previewDocRect && m_d->circleZoomPreviewEnabled) prepareZoomPreview(previewDocRect);
+    if (previewDocRect != m_d->previewDocRect) prepareZoomPreview(previewDocRect);
 
     m_d->previewDocRect = previewDocRect;
 
@@ -474,6 +474,9 @@ QRectF KisAsyncColorSamplerHelper::colorPreviewDocRect(const QPointF &docPoint)
 }
 
 void KisAsyncColorSamplerHelper::prepareZoomPreview(const QRectF &docRect) {
+    // This can be called before startAction(), so there may not be a strokeId
+    if (!m_d->circleZoomPreviewEnabled || !m_d->strokeId) return;
+
     KisImageSP image = m_d->canvas->image();
     if (!image) return;
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.