[network/ruqola] src/widgets/room: Don't leak separator. Recreate each time and not necessary as it's added in generateMessageBoxActionButtons

Laurent Montel <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit 4b1f570e235882f503819969b66e3a1d14b9adcd by Laurent Montel.
Committed on 14/08/2026 at 21:21.
Pushed by mlaurent into branch 'master'.

Don't leak separator. Recreate each time and not necessary as it's added in generateMessageBoxActionButtons

M  +0    -3    src/widgets/room/messagelineextratoolbutton.cpp

https://invent.kde.org/network/ruqola/-/commit/4b1f570e235882f503819969b66e3a1d14b9adcd

diff --git a/src/widgets/room/messagelineextratoolbutton.cpp b/src/widgets/room/messagelineextratoolbutton.cpp
index 0e5c84a428..adf6cc8c5b 100644
--- a/src/widgets/room/messagelineextratoolbutton.cpp
+++ b/src/widgets/room/messagelineextratoolbutton.cpp
@@ -95,9 +95,6 @@ void MessageLineExtraToolButton::slotActionButtonChanged()
     if (mCurrentRocketChatAccount) {
         const ActionButton::FilterActionInfo filterInfo{.buttonContext = ActionButton::ButtonContext::MessageBoxAction, .roles = {}};
         const QList<ActionButton> actionButtons = mCurrentRocketChatAccount->actionButtonsManager()->actionButtonsFromFilterActionInfo(filterInfo);
-        if (!actionButtons.isEmpty()) {
-            mMenu->addSeparator();
-        }
         // qDebug() << "*************** actionButtons " << actionButtons << "mRoomId  " << mRoomId;
         mActionButtonsGenerator->generateMessageBoxActionButtons(actionButtons, menu(), mRoomId);
         setVisible(!menu()->isEmpty());
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.