[pim/kdepim-addons] kmail/editorsendcheckplugins: addItem is not useful as we already create item with parent
Laurent Montel <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit d44ba553f243e1f457398cf6f439c0530db89635 by Laurent Montel.
Committed on 15/08/2026 at 08:21.
Pushed by mlaurent into branch 'master'.
addItem is not useful as we already create item with parent
M +1 -6 kmail/editorsendcheckplugins/checkbeforesend/checkbeforesendinterface.cpp
M +0 -1 kmail/editorsendcheckplugins/confirm-address/confirmaddresswidget.cpp
https://invent.kde.org/pim/kdepim-addons/-/commit/d44ba553f243e1f457398cf6f439c0530db89635
diff --git a/kmail/editorsendcheckplugins/checkbeforesend/checkbeforesendinterface.cpp b/kmail/editorsendcheckplugins/checkbeforesend/checkbeforesendinterface.cpp
index eae36b82a..9c5871587 100644
--- a/kmail/editorsendcheckplugins/checkbeforesend/checkbeforesendinterface.cpp
+++ b/kmail/editorsendcheckplugins/checkbeforesend/checkbeforesendinterface.cpp
@@ -77,12 +77,7 @@ bool CheckBeforeSendInterface::exec(const MessageComposer::PluginEditorCheckBefo
if (!results.isEmpty()) {
QPointer<CheckDuplicateEmailsDialog> dlg = new CheckDuplicateEmailsDialog(parentWidget());
dlg->setDuplicatedEmails(results);
- bool result = false;
- if (dlg->exec()) {
- result = true;
- } else {
- result = false;
- }
+ const bool result = dlg->exec();
delete dlg;
if (!result) {
return result;
diff --git a/kmail/editorsendcheckplugins/confirm-address/confirmaddresswidget.cpp b/kmail/editorsendcheckplugins/confirm-address/confirmaddresswidget.cpp
index 71323b2c4..baa92cb07 100644
--- a/kmail/editorsendcheckplugins/confirm-address/confirmaddresswidget.cpp
+++ b/kmail/editorsendcheckplugins/confirm-address/confirmaddresswidget.cpp
@@ -52,7 +52,6 @@ void ConfirmAddressWidget::createAddressItems(const QStringList &address, bool v
item->setCheckState(Qt::Unchecked);
item->setForeground(Qt::red);
}
- mListEmails->addItem(item);
}
}