[pim/kdepim-addons] kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests: Improve autotest
Laurent Montel <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git commit 5647c2251798fa307a847e6deded4471a89a8736 by Laurent Montel.
Committed on 15/08/2026 at 13:22.
Pushed by mlaurent into branch 'master'.
Improve autotest
M +23 -2 kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.cpp
M +1 -0 kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.h
https://invent.kde.org/pim/kdepim-addons/-/commit/5647c2251798fa307a847e6deded4471a89a8736
diff --git a/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.cpp b/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.cpp
index 9e10a4679..e853bbf80 100644
--- a/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.cpp
+++ b/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.cpp
@@ -8,7 +8,7 @@
#include "confirmbeforedeletingrule.h"
#include <QTest>
QTEST_GUILESS_MAIN(ConfirmBeforeDeletingRuleTest)
-
+using namespace Qt::Literals::StringLiterals;
ConfirmBeforeDeletingRuleTest::ConfirmBeforeDeletingRuleTest(QObject *parent)
: QObject(parent)
{
@@ -16,11 +16,32 @@ ConfirmBeforeDeletingRuleTest::ConfirmBeforeDeletingRuleTest(QObject *parent)
void ConfirmBeforeDeletingRuleTest::shouldHaveDefaultValues()
{
- ConfirmBeforeDeletingRule r;
+ const ConfirmBeforeDeletingRule r;
QVERIFY(r.pattern().isEmpty());
QVERIFY(!r.isValid());
QCOMPARE(r.ruleType(), ConfirmBeforeDeletingRule::RuleType::Unknown);
// TODO
}
+void ConfirmBeforeDeletingRuleTest::shouldBeEqual()
+{
+ ConfirmBeforeDeletingRule r;
+ r.setPattern(u"foo"_s);
+ r.setRuleType(ConfirmBeforeDeletingRule::RuleType::Body);
+ {
+ ConfirmBeforeDeletingRule r1;
+ QVERIFY(r != r1);
+ }
+ {
+ ConfirmBeforeDeletingRule r1;
+ r.setPattern(u"foo"_s);
+ QVERIFY(r != r1);
+ }
+ {
+ ConfirmBeforeDeletingRule r1;
+ r1.setPattern(u"foo"_s);
+ r1.setRuleType(ConfirmBeforeDeletingRule::RuleType::Body);
+ QVERIFY(r == r1);
+ }
+}
#include "moc_confirmbeforedeletingruletest.cpp"
diff --git a/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.h b/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.h
index dc8f50e88..fd9897027 100644
--- a/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.h
+++ b/kmail/checkbeforedeletemailplugins/confirmbeforedeleting/autotests/confirmbeforedeletingruletest.h
@@ -16,4 +16,5 @@ public:
~ConfirmBeforeDeletingRuleTest() override = default;
private Q_SLOTS:
void shouldHaveDefaultValues();
+ void shouldBeEqual();
};