[utilities/krusader] app/BookMan: BookMan: Solve 'No such signal' runtime warnings by removing code that is no longer used

Git commit 44ec4780ce9a9587abd2da27ad31f5ac1dadbd5c by Toni Asensi Esteve.
Committed on 16/08/2026 at 22:14.
Pushed by asensi into branch 'master'.

BookMan: Solve 'No such signal' runtime warnings by removing code that is no longer used

Revision: https://invent.kde.org/utilities/krusader/-/merge_requests/193

M  +3    -9    app/BookMan/krbookmarkhandler.cpp
M  +1    -1    app/BookMan/krbookmarkhandler.h

https://invent.kde.org/utilities/krusader/-/commit/44ec4780ce9a9587abd2da27ad31f5ac1dadbd5c

diff --git a/app/BookMan/krbookmarkhandler.cpp b/app/BookMan/krbookmarkhandler.cpp
index 3f5e1d027..6e96da792 100644
--- a/app/BookMan/krbookmarkhandler.cpp
+++ b/app/BookMan/krbookmarkhandler.cpp
@@ -784,13 +784,13 @@ bool KrBookmarkHandler::eventFilter(QObject *obj, QEvent *ev)
 
                 auto *bm = qobject_cast<KrBookmark *>(act);
                 if (bm != nullptr) {
-                    rightClicked(menu, bm);
+                    rightClicked(bm);
                     return true;
                 } else if (act && act->data().canConvert<QPointer<KrBookmark>>()) {
                     QPointer<KrBookmark> bmPtr = act->data().value<QPointer<KrBookmark>>();
                     // Safely check if the object still exists
                     if (bmPtr) {
-                        rightClicked(menu, bmPtr.data());
+                        rightClicked(bmPtr.data());
                     }
                     // If bmPtr is null, the object was deleted in the background; therefore, ignore the click
                 }
@@ -862,9 +862,6 @@ void KrBookmarkHandler::rightClickOnSpecialBookmark()
     act->setCheckable(true);
     act->setChecked(hasJumpback);
 
-    connect(_mainBookmarkPopup, SIGNAL(highlighted(int)), &menu, SLOT(close()));
-    connect(_mainBookmarkPopup, SIGNAL(activated(int)), &menu, SLOT(close()));
-
     int result = -1;
     QAction *res = menu.exec(QCursor::pos());
     if (res && res->data().canConvert<int>())
@@ -903,7 +900,7 @@ void KrBookmarkHandler::rightClickOnSpecialBookmark()
 #define OPEN_NEW_TAB_ID 100201
 #define DELETE_ID 100202
 
-void KrBookmarkHandler::rightClicked(QMenu *menu, KrBookmark *bm)
+void KrBookmarkHandler::rightClicked(KrBookmark *bm)
 {
     QMenu popup(_mainBookmarkPopup);
     QAction *act;
@@ -918,9 +915,6 @@ void KrBookmarkHandler::rightClicked(QMenu *menu, KrBookmark *bm)
     act = popup.addAction(Icon("edit-delete"), i18n("Delete"));
     act->setData(QVariant(DELETE_ID));
 
-    connect(menu, SIGNAL(highlighted(int)), &popup, SLOT(close()));
-    connect(menu, SIGNAL(activated(int)), &popup, SLOT(close()));
-
     // A QPointer aimed to safely track the lifetime of the bookmark
     QPointer<KrBookmark> safeBm(bm);
 
diff --git a/app/BookMan/krbookmarkhandler.h b/app/BookMan/krbookmarkhandler.h
index 17e8ef4ec..2a87b6f62 100644
--- a/app/BookMan/krbookmarkhandler.h
+++ b/app/BookMan/krbookmarkhandler.h
@@ -54,7 +54,7 @@ protected:
     void buildMenu(KrBookmark *parent, QMenu *menu, int depth = 0);
 
     bool eventFilter(QObject *obj, QEvent *ev) override;
-    void rightClicked(QMenu *menu, KrBookmark *bm);
+    void rightClicked(KrBookmark *bm);
     void rightClickOnSpecialBookmark();
 
     void removeReferences(KrBookmark *root, KrBookmark *bmToRemove);