[graphics/digikam] core/libs: cppcheck: constify

Gilles Caulier <[email protected]>
Newsgroups gmane.comp.kde.cvs
Message-ID <[email protected]>
Git commit ac370848cd441967d0cbd48137bad0f2aac2081b by Gilles Caulier.
Committed on 18/08/2026 at 07:11.
Pushed by cgilles into branch 'master'.

cppcheck: constify

M  +1    -1    core/libs/dimg/filters/fx/charcoalfilter.cpp
M  +1    -1    core/libs/dimg/filters/fx/charcoalfilter.h
M  +8    -6    core/libs/tags/widgets/addtagslineedit.cpp

https://invent.kde.org/graphics/digikam/-/commit/ac370848cd441967d0cbd48137bad0f2aac2081b

diff --git a/core/libs/dimg/filters/fx/charcoalfilter.cpp b/core/libs/dimg/filters/fx/charcoalfilter.cpp
index 8a2b6f92b8..cfc0bfecec 100644
--- a/core/libs/dimg/filters/fx/charcoalfilter.cpp
+++ b/core/libs/dimg/filters/fx/charcoalfilter.cpp
@@ -183,7 +183,7 @@ void CharcoalFilter::filterImage()
     }
 }
 
-void CharcoalFilter::convolveImageMultithreaded(uint start, uint stop, double* normal_kernel, double kernelWidth)
+void CharcoalFilter::convolveImageMultithreaded(uint start, uint stop, const double* const normal_kernel, double kernelWidth)
 {
     ActionThreadBase::setCurrentThreadName(QLatin1String(__FUNCTION__));       // To customize thread name
 
diff --git a/core/libs/dimg/filters/fx/charcoalfilter.h b/core/libs/dimg/filters/fx/charcoalfilter.h
index 7a911f2bdb..12f25c0130 100644
--- a/core/libs/dimg/filters/fx/charcoalfilter.h
+++ b/core/libs/dimg/filters/fx/charcoalfilter.h
@@ -69,7 +69,7 @@ private:
     int  getOptimalKernelWidth(double radius, double sigma);
     void convolveImageMultithreaded(uint start,
                                     uint stop,
-                                    double* normal_kernel,
+                                    const double* const normal_kernel,
                                     double kernelWidth);
 
 private:
diff --git a/core/libs/tags/widgets/addtagslineedit.cpp b/core/libs/tags/widgets/addtagslineedit.cpp
index da00a41ee3..270e021013 100644
--- a/core/libs/tags/widgets/addtagslineedit.cpp
+++ b/core/libs/tags/widgets/addtagslineedit.cpp
@@ -38,14 +38,16 @@ public:
 
     Private() = default;
 
-    TagCompleter*       completer       = nullptr;
-    TagTreeView*        tagView         = nullptr;
-    AlbumFilterModel*   tagFilterModel  = nullptr;
+public:
+
+    TagCompleter*       completer            = nullptr;
+    TagTreeView*        tagView              = nullptr;
+    AlbumFilterModel*   tagFilterModel       = nullptr;
 
     TaggingAction       currentTaggingAction;
-    int                 parentTagId     = 0;
+    int                 parentTagId          = 0;
 
-    bool                returnPressed   = false;
+    bool                returnPressed        = false;
 };
 
 AddTagsLineEdit::AddTagsLineEdit(QWidget* const parent)
@@ -93,7 +95,7 @@ void AddTagsLineEdit::setSupportingTagModel(TagModel* const model)
     d->completer->setSupportingTagModel(model);
 }
 
-void AddTagsLineEdit::setFilterModel(AlbumFilterModel* const model)
+void AddTagsLineEdit::setFilterModel(AlbumFilterModel* const model)         // cppcheck-suppress constParameterCallback
 {
     d->tagFilterModel = model;
     d->completer->setTagFilterModel(d->tagFilterModel);
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.