[qt/qtqa/gerrit]: Summary of bulk changes made
KDE Git Services - Bulk Change <[email protected]>
| Newsgroups | gmane.comp.kde.cvs |
|---|---|
| Message-ID | <[email protected]> |
Git repository change summary for qt/qtqa/gerrit Pushed by mirror-service into branch 'upstream/master'. Changed from c84d40eb4da8e63a46cc1617c187bf0ae53965f7 to 2f33091b6d3cc5d47cc503e1009776273dd90f00 Acknowledgement was received that this change introduces only existing code that has been pushed to another public open source repository. This change contains the following new commits: Git commit df24be2f18d5a627222543d50c4ea9ccf16eca06 by Milutin Kristofic on 18/08/2026 at 10:27.. Ignore Enter and navigation keys during IME composition in prompt-box When using an Input Method Editor (IME) in the prompt-box input field, pressing Enter to finalize pre-edit text (or navigating candidates) unexpectedly submitted the prompt or navigated prompt history. This happened because prompt-box's onKeyDown handler did not check whether an IME composition session was in progress. Fix this by checking event.isComposing and event.keyCode === 229 in onKeyDown and returning early when an IME composition is active. Add tests in prompt-box_test.ts verifying that Enter events during IME composition do not send the prompt. Google-Bug-Id: b/547451546 Release-Notes: Fix unexpected prompt submission when confirming IME text Change-Id: Idd2014501a2c88b8e9ed1893ca8fbcae3fbc8c2c https://invent.kde.org/qt/qtqa/gerrit/-/commit/df24be2f18d5a627222543d50c4ea9ccf16eca06 Git commit 8586664870fa88072e33aedeacf4d4cae48d3401 by Milutin Kristofic on 18/08/2026 at 11:20.. Fix extra dot in linkified Flag fields When resolving commentlinks, getReplacementText was re-evaluating the regex standalone on the matched text. This caused mismatches when the regex relied on context that was lost in the standalone string, such as word boundaries (\b) at the end of the match. This regression was introduced in commit 8631e4bd59 (https://gerrit.googlesource.com/gerrit/+/8631e4bd599488a3c92e49b2695655318e1ecb95), which resolved templates before creating the link template to fix same-origin checks. For example, with "Flag: build.RELEASE...", the regex matched "Flag: build." in context because of the boundary before "RELEASE". But standalone, "Flag: build." has no boundary at the end, so the regex only matched "Flag: build", leaving the dot "." as unmatched trailing text. This unmatched dot was then incorrectly prepended to the link, rendering as "Flag: .build.RELEASE...". Fix this by reusing the original match groups (RegExpExecArray) that were found in the base string, avoiding re-evaluation entirely. This preserves the same-origin check fix from 8631e4bd59 but avoids the context-loss regression. Google-Bug-Id: b/526406326 Release-Notes: Fix extra dot in linkified Flag fields Change-Id: I480185e03ad2b9e6d8b772b25ab6b51ec532cb06 https://invent.kde.org/qt/qtqa/gerrit/-/commit/8586664870fa88072e33aedeacf4d4cae48d3401 Git commit 921183558d392a6d9f9b2ced39905709f6f285d6 by Gerrit Code Review (on behalf of Milutin Kristofic) on 18/08/2026 at 11:34.. Merge "Fix extra dot in linkified Flag fields" https://invent.kde.org/qt/qtqa/gerrit/-/commit/921183558d392a6d9f9b2ced39905709f6f285d6 Git commit 2f33091b6d3cc5d47cc503e1009776273dd90f00 by Gerrit Code Review (on behalf of Milutin Kristofic) on 18/08/2026 at 11:36.. Merge "Ignore Enter and navigation keys during IME composition in prompt-box" https://invent.kde.org/qt/qtqa/gerrit/-/commit/2f33091b6d3cc5d47cc503e1009776273dd90f00