Re: A weird problem with ktts/jovie

Salı 20 Temmuz 2010 günü (saat 14:00:01) Ozan Çağlayan şunları yazmıştı:
> Pazartesi 19 Temmuz 2010 günü (saat 16:13:33) Ozan Çağlayan şunları 
yazmıştı:
> > Hi,
> > 
> > I was experimenting with kttsd on KDE 4.4 but I encounter a very strange
> > problem that I couldn't find any trace on google.
> > 
> > When I add some talkers through kttsmgr and click Apply, the kttsdrc file
> > doesn't get written correctly. I mean, the TalkerIDs= should be something
> > like according to the code:
> > 
> > id1,id2,..,idN
> > 
> > but on my system the IDs never shows up instead it is empty strings
> > separated by a comma ','. If I add 3 talkers the conf looks like:
> > 
> > TalkerIDs=,,
> 
> Omg, we have to provide a Name in the talker configuration or else the
> configuration gets bloated but the selector widget allows to leave the name
> empty. I think that should be fixed in terms of human interface guidelines.


The attached patch at least avoids people leaving the Name field empty.

---
Ozan Çağlayan
TUBITAK/UEKAE - Pardus Linux
http://www.pardus.org.tr/eng

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility

Index: kcmkttsmgr/talkerwidget.cpp
===================================================================
--- kcmkttsmgr/talkerwidget.cpp	(revision 1151708)
+++ kcmkttsmgr/talkerwidget.cpp	(working copy)
@@ -45,6 +45,8 @@
 {
     mUi = new Ui::TalkerWidget;
     mUi->setupUi(this);
+    connect(mUi->nameEdit, SIGNAL(textEdited(const QString&)),
+            this, SIGNAL(talkerChanged()));
     connect(mUi->AvailableTalkersTable, SIGNAL(itemSelectionChanged()),
             this, SIGNAL(talkerChanged()));
     connect(mUi->voiceComboBox, SIGNAL(currentIndexChanged(int)),
@@ -121,6 +123,11 @@
 {
 }
 
+QString TalkerWidget::getName() const
+{
+    return mUi->nameEdit->text();
+}
+
 TalkerCode TalkerWidget::getTalkerCode() const
 {
     TalkerCode retval;
Index: kcmkttsmgr/addtalker.cpp
===================================================================
--- kcmkttsmgr/addtalker.cpp	(revision 1151708)
+++ kcmkttsmgr/addtalker.cpp	(working copy)
@@ -64,7 +64,7 @@
 
 void AddTalker::slotTalkerChanged()
 {
-    this->enableButtonOk(true);
+    this->enableButtonOk(!mWidget->getName().isEmpty());
 }
 
 #include "addtalker.moc"