Review Request: W7 Tab thumbnails in dolphin.
"Andrius da Costa Ribas" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility,gmane.comp.kde.windows,gmane.comp.kde.devel.core |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102758/ ----------------------------------------------------------- Review request for KDE Base Apps, KDE Accessibility, kdewin, Patrick Spendrin, and Peter Penz. Description ------- Add Windows 7 tab thumbnails feature to dolphin. Mostly based on the example from <http://nicug.blogspot.com/2011/03/windows-7-taskbar-extensions-in-qt-tab.html>. An icon representation is used instead of actual thumbnails ( please agree that those microscopic previews are not useful at all ;] ). Changing an icon when url changes is also easier than checking all the time whether something inside the window has been changed. Using icons is a lot more KDE-ish and therefore more beautiful and user-friendly than the default Windows behavior ;). "win7utils.h" and "win7utils.cpp" are from <https://github.com/xfreebird/blogstuff/tree/master/qt/thumbnailtabs_example1> with few adaptations. Diffs ----- dolphin/src/CMakeLists.txt 93225c5 dolphin/src/dolphinapplication.h 69d07c3 dolphin/src/dolphinapplication.cpp 0dc9c96 dolphin/src/dolphinmainwindow.h 9fb83bf dolphin/src/dolphinmainwindow.cpp 6ca6e59 dolphin/src/platform/win7utils.h PRE-CREATION dolphin/src/platform/win7utils.cpp PRE-CREATION Diff: http://git.reviewboard.kde.org/r/102758/diff/diff Testing ------- Tested using MSVC 2010 32 bit, in a Windows 7 64 bit machine. May need testing: - Compiling under mingw-w32 and mingw-w64 - Using Windows Vista or below to ensure there are no side-efects on a box without this feature. - Using Windows 8 (I don't know much about its bugs^H^H^H^Hfeatures ;] ) Known problems: - There is no way to know if KTabBar got a tab reordered, so the "thumbnails" won't be reordered, but their reference is still correct - Undefined behavior when dolphin gets unresponsive [e.g.: because of a defective kioslave], most of the code assume dolphin is okay [e.g.: QPixmap::grabWidget won't work in a frozen window]. Screenshots ----------- Tabs! http://git.reviewboard.kde.org/r/102758/s/281/ More Tabs! http://git.reviewboard.kde.org/r/102758/s/282/ Too many tabs! http://git.reviewboard.kde.org/r/102758/s/283/ Thanks, Andrius da Costa Ribas _______________________________________________ kde-accessibility mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-accessibility