Re: Review Request: W7 Tab thumbnails in dolphin.

> On Oct. 3, 2011, 7:28 a.m., Peter Penz wrote:
> > I always recommend to get in contact with the maintainers of an application _before_ investigating so much work into a new feature. In this case I'm very sorry to say that this cannot get pushed because of the following reasons:
> > - I'm unable to maintain this code as I don't do any Dolphin development on Windows (and cannot do it because of having limited time)
> > - I'd like to keep platform dependent code in Dolphin as minimal as possible
> > - For the 4.9 release of the KDE applications (= Dolphin 2.1) a long overdue cleanup of DolphinMainWindow will be done (separated code for tabs etc) and I won't be able to refactor this platform specific code :-(
> 
> Patrick Spendrin wrote:
>     I think that we would also maintain this code part as we already do for other parts in KDE, so you normally shouldn't need to work on that.
>     It would be nice if you could let us participate in the refactoring process for 4.9 so that we can adapt this patch early & according to your wishes.

Sure, I'll drop you a note as soon as I'm cleaning up the mainwindow-code for 4.9. It sounds fine that you would be willing to maintain this code - I'm just generally wondering: Do you plan to add such window-specific code to each KDE application providing tabs? I'm still not really happy with having that much platform specific code inside the application... Well, probably I'll change my opinion but I would be interested how other application developers see this :-)


- Peter


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102758/#review7010
-----------------------------------------------------------


On Oct. 3, 2011, 1:25 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102758/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2011, 1:25 a.m.)
> 
> 
> Review request for KDE Base Apps, KDE Accessibility, kdewin, Patrick Spendrin, and Peter Penz.
> 
> 
> Description
> -------
> 
> Add Windows 7 tab thumbnails feature to dolphin.
> Mostly based on the example from <http://nicug.blogspot.com/2011/03/windows-7-taskbar-extensions-in-qt-tab.html>.
> 
> An icon representation is used instead of actual thumbnails ( please agree that those microscopic previews are not useful at all ;] ). Changing an icon when url changes is also easier than checking all the time whether something inside the window has been changed. Using icons is a lot more KDE-ish and therefore more beautiful and user-friendly than the default Windows behavior ;).
> 
> "win7utils.h" and "win7utils.cpp" are from <https://github.com/xfreebird/blogstuff/tree/master/qt/thumbnailtabs_example1> with few adaptations.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/CMakeLists.txt 93225c5 
>   dolphin/src/dolphinapplication.h 69d07c3 
>   dolphin/src/dolphinapplication.cpp 0dc9c96 
>   dolphin/src/dolphinmainwindow.h 9fb83bf 
>   dolphin/src/dolphinmainwindow.cpp 6ca6e59 
>   dolphin/src/platform/win7utils.h PRE-CREATION 
>   dolphin/src/platform/win7utils.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/102758/diff/diff
> 
> 
> Testing
> -------
> 
> Tested using MSVC 2010 32 bit, in a Windows 7 64 bit machine.
> 
> May need testing:
> - Compiling under mingw-w32 and mingw-w64
> - Using Windows Vista or below to ensure there are no side-efects on a box without this feature.
> - Using Windows 8 (I don't know much about its bugs^H^H^H^Hfeatures ;] )
> 
> Known problems:
> - There is no way to know if KTabBar got a tab reordered, so the "thumbnails" won't be reordered, but their reference is still correct
> - Undefined behavior when dolphin gets unresponsive [e.g.: because of a defective kioslave], most of the code assume dolphin is okay [e.g.: QPixmap::grabWidget won't work in a frozen window]. 
> 
> 
> Screenshots
> -----------
> 
> Tabs!
>   http://git.reviewboard.kde.org/r/102758/s/281/
> More Tabs!
>   http://git.reviewboard.kde.org/r/102758/s/282/
> Too many tabs!
>   http://git.reviewboard.kde.org/r/102758/s/283/
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

_______________________________________________
Kde-windows mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-windows