Re: Review Request: Handle menus with separators

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105882/#review16973
-----------------------------------------------------------



src/atspiadaptor.cpp
<http://git.reviewboard.kde.org/r/105882/#comment13336>

    I find the code much easier to read if the initialization is done here, not in the else. You can still re-assign inside the if-loop.



src/atspiadaptor.cpp
<http://git.reviewboard.kde.org/r/105882/#comment13335>

    Declaration and initialization could be one line.



src/atspiadaptor.cpp
<http://git.reviewboard.kde.org/r/105882/#comment13337>

    I don't think the inner check makes sense to be honest. QAction needs a proper parent for the accessibility to work, but it simply doesn't know about it's parent.


- Frederik Gladhorn


On Aug. 5, 2012, 6:06 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105882/
> -----------------------------------------------------------
> 
> (Updated Aug. 5, 2012, 6:06 p.m.)
> 
> 
> Review request for KDE Accessibility and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> This patch makes screen readers work well with menus when there are separators in the menu.
> 
> 
> Diffs
> -----
> 
>   src/atspiadaptor.cpp 9dcd521 
> 
> Diff: http://git.reviewboard.kde.org/r/105882/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility