Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets
"Amandeep Singh" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility,gmane.comp.kde.devel.kfm,gmane.comp.kde.devel.core |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/ ----------------------------------------------------------- (Updated Aug. 13, 2012, 5:50 a.m.) Review request for Dolphin, KDE Base Apps and KDE Accessibility. Changes ------- Thanks for the review. :) QAccessible class defines static functions & enums for Accessibility. And the QAccessibileInterface must be implemented for a widget to be accessible to accessibility clients like screen-readers, magnifiers, etc. I added the Accessible Interface for KItemListContainer, KItemListView and KitemListWidgets, to make dolphin accessible. This particular patch makes it work with KMag, which can now track where the keyboard focus is, within the dolphin view. With some improvements/additions in the Accessibile interface, it will work great with screen-readers as well. As you suggested, I removed the unnecessary dependency from KItemListSelectionManger, and also tried to remove the commented code and make it compatible with KDE code policies. Description ------- Added Accessibility Interfaces for Dolphin Views & Widgets, to make it accessible. 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that contain the three new classes. Diffs (updated) ----- dolphin/src/CMakeLists.txt 5c1a6da dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f dolphin/src/kitemviews/kitemlistselectionmanager.cpp 383914d dolphin/src/kitemviews/kitemlistview.h 5723b9a dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d dolphin/src/tests/CMakeLists.txt 3f906d1 Diff: http://git.reviewboard.kde.org/r/105972/diff/ Testing ------- Focus-tracking tested with KMag / KWin. Thanks, Amandeep Singh _______________________________________________ kde-accessibility mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-accessibility