Re: Review Request: Focus Tracking in KWin's Zoom Plugin
"Sebastian Sauer" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility,gmane.comp.kde.devel.kwin |
|---|---|
| Message-ID | <[email protected]> |
> On Aug. 15, 2012, 7:22 p.m., Thomas Lübking wrote: > > kwin/effects/zoom/zoom.cpp, line 231 > > <http://git.reviewboard.kde.org/r/106041/diff/2/?file=77996#file77996line231> > > > > Is this some sort of blocking dbus call? Yes, it was. Good spot. Fixed with commit ccabdcef6c3d9 in libkdeaccessibilityclient. - Sebastian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106041/#review17472 ----------------------------------------------------------- On Aug. 15, 2012, 3:07 p.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106041/ > ----------------------------------------------------------- > > (Updated Aug. 15, 2012, 3:07 p.m.) > > > Review request for KDE Accessibility, kwin, Frederik Gladhorn, Sebastian Sauer, and Luboš Luňák. > > > Description > ------- > > This patch is for KWin, makes the focus-tracking feature of KWin work with applications. This makes KDE more accessible. > A new accessibility client library "libkdeaccessibilityclient" (which can be found here: https://projects.kde.org/projects/playground/accessibility/libkdeaccessibilityclient) is also to be added in kde-support. > > The focus-tracking feature will use the new library to get the accessibility information from at-spi. > > Adjustments in CMakeLists have been made to add the library as an optional dependency, which if found enables the focus-tracking option in Zoom Plugin. > And in absence of library, the option is removed. > > > Diffs > ----- > > kwin/effects/CMakeLists.txt 29accb1 > kwin/effects/zoom/CMakeLists.txt 36e11ac > kwin/effects/zoom/focustrackconfig.h.in PRE-CREATION > kwin/effects/zoom/zoom.h d809b21 > kwin/effects/zoom/zoom.cpp b275b1e > kwin/effects/zoom/zoom_config.cpp 3edd10c > > Diff: http://git.reviewboard.kde.org/r/106041/diff/ > > > Testing > ------- > > I tested KWin's new feature working with KWrite and Konsole. > > > Thanks, > > Amandeep Singh > > _______________________________________________ kde-accessibility mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-accessibility