Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets
"Frederik Gladhorn" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility,gmane.comp.kde.devel.core,gmane.comp.kde.devel.kfm |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105972/#review17795
-----------------------------------------------------------
dolphin/src/kitemviews/kitemlistviewaccessible.cpp
<http://git.reviewboard.kde.org/r/105972/#comment14034>
The spaces are weird in this line.
dolphin/src/kitemviews/kitemlistviewaccessible.cpp
<http://git.reviewboard.kde.org/r/105972/#comment14035>
I think increasing by one is wrong here.
eg 9 items in 3 rows and 3 columns would return 4 here.
dolphin/src/kitemviews/kitemlistviewaccessible.cpp
<http://git.reviewboard.kde.org/r/105972/#comment14036>
Sibling is not very important. It will be removed in Qt 5 and can be ignored. But you can leave it for now.
- Frederik Gladhorn
On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/105972/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2012, 11:20 a.m.)
>
>
> Review request for Dolphin, KDE Base Apps and KDE Accessibility.
>
>
> Description
> -------
>
> Added Accessibility Interfaces for Dolphin Views & Widgets, to make it accessible.
> 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that contain the three new classes.
>
>
> Diffs
> -----
>
> dolphin/src/CMakeLists.txt afc190f
> dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f
> dolphin/src/kitemviews/kitemlistview.h 5723b9a
> dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8
> dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION
> dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION
> dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d
> dolphin/src/tests/CMakeLists.txt 3f906d1
>
> Diff: http://git.reviewboard.kde.org/r/105972/diff/
>
>
> Testing
> -------
>
> Focus-tracking tested with KMag / KWin.
>
>
> Thanks,
>
> Amandeep Singh
>
>
_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility