Re: Review Request: Adding Accessibility Interfaces for Dolphin Views & Widgets
"Amandeep Singh" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility,gmane.comp.kde.devel.core,gmane.comp.kde.devel.kfm |
|---|---|
| Message-ID | <[email protected]> |
> On Aug. 21, 2012, 9:44 a.m., Frederik Gladhorn wrote: > > dolphin/src/kitemviews/kitemlistviewaccessible.cpp, line 71 > > <http://git.reviewboard.kde.org/r/105972/diff/5/?file=78194#file78194line71> > > > > I think increasing by one is wrong here. > > eg 9 items in 3 rows and 3 columns would return 4 here. No, if there are total 9 items and 3 columns, then rowCount will be 3. And in such a case the if() will not be executed since 9%3 == 0. - Amandeep ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105972/#review17795 ----------------------------------------------------------- On Aug. 17, 2012, 11:20 a.m., Amandeep Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/105972/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2012, 11:20 a.m.) > > > Review request for Dolphin, KDE Base Apps and KDE Accessibility. > > > Description > ------- > > Added Accessibility Interfaces for Dolphin Views & Widgets, to make it accessible. > 2 New files added in dolphin/ src/ kitemviews/ kitemlistviewaccessible.* that contain the three new classes. > > > Diffs > ----- > > dolphin/src/CMakeLists.txt afc190f > dolphin/src/kitemviews/kitemlistcontroller.cpp 88f5d9f > dolphin/src/kitemviews/kitemlistview.h 5723b9a > dolphin/src/kitemviews/kitemlistview.cpp 72b3fd8 > dolphin/src/kitemviews/kitemlistviewaccessible.h PRE-CREATION > dolphin/src/kitemviews/kitemlistviewaccessible.cpp PRE-CREATION > dolphin/src/kitemviews/private/kitemlistviewlayouter.h da5bd1d > dolphin/src/tests/CMakeLists.txt 3f906d1 > > Diff: http://git.reviewboard.kde.org/r/105972/diff/ > > > Testing > ------- > > Focus-tracking tested with KMag / KWin. > > > Thanks, > > Amandeep Singh > > _______________________________________________ kde-accessibility mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-accessibility