Re: Review Request: Handle TableModelChange

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106178/#review18312
-----------------------------------------------------------

Ship it!


Looks good to me, I guess it mostly depends on the Qt changes going in then :)
Just a bit of nit-picking.
For Qt 5 we'll have to revisit this in a hopefully nicer manner.


src/atspiadaptor.cpp
<http://git.reviewboard.kde.org/r/106178/#comment14485>

    you can simply do if (qobject_cast...) return;
    No need to create the variable explicitly.



src/atspiadaptor.cpp
<http://git.reviewboard.kde.org/r/106178/#comment14484>

    trailing whitespace


- Frederik Gladhorn


On Aug. 25, 2012, 2:39 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106178/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 2:39 p.m.)
> 
> 
> Review request for KDE Accessibility and Frederik Gladhorn.
> 
> 
> Description
> -------
> 
> AtSpiAdaptor::handleModelChange was created to be handle TableModelChange event.
>     
> This method will be called when notify is called with TableModel change and will send PropertyChange signals with name and description as arguments.
> 
> In order to test this patch, the following patches have to be applied to Qt:
>  - https://codereview.qt-project.org/33549
>  - https://codereview.qt-project.org/33550
> 
> 
> Diffs
> -----
> 
>   src/atspiadaptor.h 56b9790 
>   src/atspiadaptor.cpp 84839ae 
> 
> Diff: http://git.reviewboard.kde.org/r/106178/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility