Re: Review Request: Focus Tracking in KWin's Zoom Plugin

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106041/
-----------------------------------------------------------

(Updated Sept. 6, 2012, 4:53 p.m.)


Review request for KDE Accessibility, kwin, Frederik Gladhorn, Sebastian Sauer, and Luboš Luňák.


Changes
-------

Sorry for the really long delay.
Uploading the diff with the changes required.


Description
-------

This patch is for KWin, makes the focus-tracking feature of KWin work with applications. This makes KDE more accessible.
A new accessibility client library "libkdeaccessibilityclient" (which can be found here: https://projects.kde.org/projects/playground/accessibility/libkdeaccessibilityclient) is also to be added in kde-support.

The focus-tracking feature will use the new library to get the accessibility information from at-spi.

Adjustments in CMakeLists have been made to add the library as an optional dependency, which if found enables the focus-tracking option in Zoom Plugin.
And in absence of library, the option is removed.


Diffs (updated)
-----

  CMakeLists.txt 451a8b9 
  config-workspace.h.cmake 4a2dcbf 
  kwin/effects/CMakeLists.txt 29accb1 
  kwin/effects/configs_builtins.cpp b291e38 
  kwin/effects/zoom/CMakeLists.txt 36e11ac 
  kwin/effects/zoom/zoom.h d809b21 
  kwin/effects/zoom/zoom.cpp b275b1e 
  kwin/effects/zoom/zoom_config.cpp 3edd10c 

Diff: http://git.reviewboard.kde.org/r/106041/diff/


Testing
-------

I tested KWin's new feature working with KWrite and Konsole.


Thanks,

Amandeep Singh

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility