Re: Review Request: Accessibility support for KMix

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106584/#review20000
-----------------------------------------------------------

Ship it!


Looks fine.  I am just wondering why the strings are sometimes different, e.g:
"Visible channels" vs "Enabled channels"
"Available channels" vs "Disabled channels"

Using "Master channel selection" instead of "Configure" is a good idea, though. I should also use it as caption for the Dailog

- Christian Esken


On Sept. 26, 2012, 7:28 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106584/
> -----------------------------------------------------------
> 
> (Updated Sept. 26, 2012, 7:28 p.m.)
> 
> 
> Review request for KDE Accessibility and KDE Multimedia.
> 
> 
> Description
> -------
> 
> Accessible names were given to:
>  - Volume sliders
>  - Widgets in "Configure channels..." dialog
>  - List of channels in master volume dialog
> 
> 
> Diffs
> -----
> 
>   gui/dialogselectmaster.cpp b7a252e 
>   gui/dialogviewconfiguration.cpp e9cfddd 
>   gui/mdwslider.cpp 4454510 
> 
> Diff: http://git.reviewboard.kde.org/r/106584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

_______________________________________________
kde-multimedia mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-multimedia