Re: Review Request: Accessibility support for KMix

"Christian Esken" <[email protected]>
Newsgroups gmane.comp.kde.users.multimedia,gmane.comp.kde.devel.accessibility
Message-ID <[email protected]>
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/106584/#review20252
-----------------------------------------------------------

Ship it!


Looks good. Thanks for the contribution, José.
I will apply your patch manually, as applying to mdwslider.cpp was rejected due to my recent code changes in trunk.

- Christian Esken


On Oct. 10, 2012, 6:41 p.m., José Millán Soto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/106584/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2012, 6:41 p.m.)
> 
> 
> Review request for KDE Accessibility and KDE Multimedia.
> 
> 
> Description
> -------
> 
> Accessible names were given to:
>  - Volume sliders
>  - Widgets in "Configure channels..." dialog
>  - List of channels in master volume dialog
> 
> 
> Diffs
> -----
> 
>   gui/dialogselectmaster.cpp 592a44d 
>   gui/dialogviewconfiguration.cpp 44b0892 
>   gui/mdwslider.cpp bb3af65 
> 
> Diff: http://git.reviewboard.kde.org/r/106584/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> José Millán Soto
> 
>

_______________________________________________
kde-multimedia mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-multimedia
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.