Re: Review Request: Allow opening context menu from keyboard in volume slider
"Christian Esken" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility,gmane.comp.kde.users.multimedia |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106585/#review22992 ----------------------------------------------------------- Ship it! Thanks for your additional submission. The patch looks fine to me and as it is part of the accesebility patch this belongs to KDE 4.10. I will commit it in a couple of minutes. - Christian Esken On Dec. 4, 2012, 2:34 p.m., José Millán Soto wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/106585/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2012, 2:34 p.m.) > > > Review request for KDE Accessibility and KDE Multimedia. > > > Description > ------- > > The context menu of the volume sliders in KMix can only be opened when right-clicking a slider. This is an accessibility problem as users who cannot use a mouse cannot open the menu. > This patch allows to open the context menu using the context menu key. > > > Diffs > ----- > > gui/mdwenum.h ad93d36 > gui/mdwenum.cpp 822502e > gui/mdwslider.h d42944b > gui/mdwslider.cpp 4ab1707 > gui/mixdevicewidget.h 85908ae > gui/mixdevicewidget.cpp 727651a > > Diff: http://git.reviewboard.kde.org/r/106585/diff/ > > > Testing > ------- > > > Thanks, > > José Millán Soto > > _______________________________________________ kde-accessibility mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-accessibility