Re: Review Request 109473: Added a counter to prevent a never ending loop if a job cannot connect to speech dispatcher.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109473/#review29165
-----------------------------------------------------------



jovie/jovie.h
<http://git.reviewboard.kde.org/r/109473/#comment21772>

    Please don't mix the comment changes and whitespace changes with the bug fix.



jovie/speaker.cpp
<http://git.reviewboard.kde.org/r/109473/#comment21770>

    This wont work because you reinitialize count to 0 every time the while loop loops. Move the int count = 0; line outside the loop.


- Jeremy Paul Whiting


On March 13, 2013, 4:50 p.m., Ovidiu-Florin Bogdan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109473/
> -----------------------------------------------------------
> 
> (Updated March 13, 2013, 4:50 p.m.)
> 
> 
> Review request for KDE Accessibility.
> 
> 
> Description
> -------
> 
> If a job cannot connect to speech dispatcher it would have tried to connect again and again for ever. Stuck in a never ending loop.
> I have limited the loop to only 10 tries.
> 
> 
> Diffs
> -----
> 
>   jovie/jovie.h 5f0c3b7 
>   jovie/speaker.cpp 3aea565 
> 
> Diff: http://git.reviewboard.kde.org/r/109473/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ovidiu-Florin Bogdan
> 
>

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility