Re: Review Request 111267: Automatic detection of SNR in Simon without having to go through the tool for training

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/111267/#review35235
-----------------------------------------------------------



simonlib/simonsound/devicevolumewidget.h
<http://git.reviewboard.kde.org/r/111267/#comment25800>

    Remove white space at the end of the line.
    You should be able to configure your editor to do this automatically as well.



simonlib/simonsound/devicevolumewidget.h
<http://git.reviewboard.kde.org/r/111267/#comment25801>

    Move it up to below snrOk, please.



simonlib/simonsound/devicevolumewidget.cpp
<http://git.reviewboard.kde.org/r/111267/#comment25805>

    Move code that's equal for both branches out of the if



simonlib/simonsound/devicevolumewidget.cpp
<http://git.reviewboard.kde.org/r/111267/#comment25802>

    set lowLevel = highLevel = ...;



simonlib/simonsound/devicevolumewidget.cpp
<http://git.reviewboard.kde.org/r/111267/#comment25803>

    ... you can then start from i=1



simonlib/simonsound/devicevolumewidget.cpp
<http://git.reviewboard.kde.org/r/111267/#comment25806>

    use qMin, qMax instead of ifs



simonlib/simonsound/devicevolumewidget.cpp
<http://git.reviewboard.kde.org/r/111267/#comment25818>

    No magic numbers, please.
    There's already a configuration option for minimum SNR that you should respect.
    The value from the configuration is the minimum difference of larger / lower.



simonlib/simonsound/devicevolumewidget.cpp
<http://git.reviewboard.kde.org/r/111267/#comment25819>

    Alternate text: "High levels of background noise detected. Please check your microphone and disable "Mic Boost" if enabled"
    The icon also shouldn't be dialog-ok-apply but some sort of warning (check what's available by looking at your systems icon set)


- Peter Grasch


On June 27, 2013, 9:09 a.m., Sanjiban Bairagya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/111267/
> -----------------------------------------------------------
> 
> (Updated June 27, 2013, 9:09 a.m.)
> 
> 
> Review request for KDE Accessibility and Peter Grasch.
> 
> 
> Description
> -------
> 
> This patch attempts to make an individual be able to check if the signal-to-noise-ratio detected by his/her mic is sufficiently high or not just by talking infront of the mic, without having to do any training separately.
> 
> 
> Diffs
> -----
> 
>   simonlib/simonsound/devicevolumewidget.h 06f4e0f 
>   simonlib/simonsound/devicevolumewidget.cpp 6163aa8 
> 
> Diff: http://git.reviewboard.kde.org/r/111267/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sanjiban Bairagya
> 
>

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility