Re: Review Request 125042: Fix top buttons (close button, hide numpad button)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125042/#review84813
-----------------------------------------------------------



src/kbdtray.cpp (line 42)
<https://git.reviewboard.kde.org/r/125042/#comment58692>

    Add i18n("....")



src/kvkbdapp.h (line 38)
<https://git.reviewboard.kde.org/r/125042/#comment58693>

    Why remove uniqueapplication ?



src/kvkbdapp.cpp (line 421)
<https://git.reviewboard.kde.org/r/125042/#comment58694>

    showGroup != "hideWhen..."



src/kvkbdapp.cpp (line 431)
<https://git.reviewboard.kde.org/r/125042/#comment58695>

    Remove this->



src/kvkbdapp.cpp (line 434)
<https://git.reviewboard.kde.org/r/125042/#comment58696>

    if (showGroup != ...")


- Laurent Montel


On sep. 4, 2015, 9:54 matin, Fredrick Brennan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125042/
> -----------------------------------------------------------
> 
> (Updated sep. 4, 2015, 9:54 matin)
> 
> 
> Review request for KDE Accessibility.
> 
> 
> Repository: kvkbd
> 
> 
> Description
> -------
> 
> Fix top buttons (close button, hide numpad button)
> 
> 
> Diffs
> -----
> 
>   src/kbddock.cpp 4800022 
>   src/kbdtray.cpp a9cf135 
>   src/kvkbdapp.h 498f842 
>   src/kvkbdapp.cpp 825979a 
>   src/main.cpp 49ba346 
>   src/standart.xml 7b66c89 
>   src/themeloader.cpp f3d8e60 
>   src/vbutton.cpp 7f7cead 
> 
> Diff: https://git.reviewboard.kde.org/r/125042/diff/
> 
> 
> Testing
> -------
> 
> Hello,
> 
> The top buttons of kvkbd weren't working properly on 
> 
> * Qt: 4.8.7
> * KDE Development Platform: 4.14.11
> 
> No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled.
> 
> This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled.
> 
> 
> Thanks,
> 
> Fredrick Brennan
> 
>

_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility