Re: Review Request 125042: Fix top buttons (close button, hide numpad button)
"Fredrick Brennan" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility |
|---|---|
| Message-ID | <[email protected]> |
----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125042/ ----------------------------------------------------------- (Updated Sept. 4, 2015, 11:48 a.m.) Review request for KDE Accessibility. Changes ------- Use ConstIterator instead of regular iterator, close issue Repository: kvkbd Description ------- Fix top buttons (close button, hide numpad button) Diffs (updated) ----- src/main.cpp 49ba346 src/kvkbdapp.cpp 825979a src/kvkbdapp.h 498f842 src/kbdtray.cpp a9cf135 src/kbddock.cpp 4800022 src/mainwidget.cpp 5db552e src/standart.xml 7b66c89 src/themeloader.cpp f3d8e60 src/vbutton.cpp 7f7cead Diff: https://git.reviewboard.kde.org/r/125042/diff/ Testing ------- Hello, The top buttons of kvkbd weren't working properly on * Qt: 4.8.7 * KDE Development Platform: 4.14.11 No tooltips appeared, they had no labels and they moved if the numpad was enabled/disabled. This patch adds labels, fixes tooltips (so people can actually figure out what they do, gray/red isn't very helpful) and makes it so they no longer move when numpad enabled/disabled. Thanks, Fredrick Brennan _______________________________________________ kde-accessibility mailing list [email protected] https://mail.kde.org/mailman/listinfo/kde-accessibility