Re: Review Request 126483: Use SHARE_INSTALL_PREFIX to install appstream data
"Rex Dieter" <[email protected]>
| Newsgroups | gmane.comp.kde.devel.accessibility |
|---|---|
| Message-ID | <[email protected]> |
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126483/#review89997
-----------------------------------------------------------
Ship it!
+1, that's the convention most other kde modules use.
- Rex Dieter
On Dec. 23, 2015, 11:35 a.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126483/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2015, 11:35 a.m.)
>
>
> Review request for KDE Accessibility and Jeremy Whiting.
>
>
> Repository: jovie
>
>
> Description
> -------
>
> ...instead of hard-coding share/.. which is not helpful on a multiarch
> layout, where the prefix might be something like /usr/${arch} but arch
> independent files should still go into /usr/share.
>
>
> Diffs
> -----
>
> jovie/CMakeLists.txt 66b25f7
>
> Diff: https://git.reviewboard.kde.org/r/126483/diff/
>
>
> Testing
> -------
>
> jovie.appdata.xml gets installed into the desired location.
>
>
> Thanks,
>
> Heiko Becker
>
>
_______________________________________________
kde-accessibility mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-accessibility