Re: Little patch
Rob Kaper <[email protected]>
| Newsgroups | gmane.comp.kde.devel.atlantik |
|---|---|
| Message-ID | <[email protected]> |
On Mon, Jun 02, 2003 at 08:14:35PM +0200, Albert 'TSDgeos' Astals Cid wrote: > It corrects a segmentation fault added for my previous patch :-/ > > If you openend atlantik and closed it, it segfaulted, because m_job was not > initialized to NULL. > > I've also added a timer, if the connection doesn't makes signals of life > (slotData) in less than 10 seconds the job is cancelled as i think it is > pretty safe to think that the connection is having problems. > > Along with this, now when you click on "Refresh server list " the button > becomes not enabled, because previously you could click hundred of times and > it started a hundred of m_job > > What do you think of it? I think it's better to use a static singleshot timer.. and I believe KDE uses 0(L) instead of NULL for portability reasons. I'll commit with a few changes, thanks! Rob -- Rob Kaper | "They that can give up essential liberty to obtain a little [email protected] | temporary safety deserve neither liberty nor safety." www.capsi.com | - Benjamin Franklin, Historical Review of Pennsylvania, 1759 _______________________________________________ atlantik-devel mailing list [email protected] http://mail.kde.org/mailman/listinfo/atlantik-devel
signature.asc
(application/pgp-signature, 189 B)
-----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (GNU/Linux) iD8DBQE+25UmtppIl2G1SjcRAk7sAJ9XMEHCJVRQK2R3AVxA19aaZsB9VgCeOnzd sacGxTxY5TDybKZjhR1lRAI= =994e -----END PGP SIGNATURE-----