Re: PyKF5 use of the SIP second declaration
Shaheed Haque <[email protected]>
| Newsgroups | gmane.comp.kde.devel.bindings |
|---|---|
| Message-ID | <CAHAc2jdxPfJv3-ss6Dhn5tkjURkvGZgWM8PfOio8MFP+eru+cw@mail.gmail.com> |
Just to close this thread...in the review I just posted, I renamed the stuff like this: decl2 -> cxx_decl fn_result2 -> cxx_fn_result On 21 January 2017 at 12:34, Shaheed Haque <[email protected]> wrote: > Thanks for confirming. > > As for the second declaration etc, the SIP specification at > http://pyqt.sourceforge.net/Docs/sip4/specification_files.html refers to > it as the "*c++-signature*", so I'll look into replacing the number with > a suffix like "_cpp". > > Thanks, Shaheed > > On 21 January 2017 at 10:58, Stephen Kelly <[email protected]> wrote: > >> Shaheed Haque wrote: >> >> > Hi Steve, >> > >> > Another smallpoint to resolve is around the logic for the support of the >> > second declaration in SIP files, e.g. the bit in [] brackets here: >> >> > I suggest that for consistency the second set of parameters should also >> be >> > an array: >> >> That makes sense to me. >> >> I'm not a fan of numbers in interfaces though. Can you choose alternate >> names which convey what the second set of values are for? >> >> Thanks, >> >> Steve. >> >> >