Re: PyKF5 bindings generator improvements out for review.

Shaheed Haque wrote:

> All the code is squashed into the single commit. Feedback welcome here or
> via reviewboard or via github.

Hi Shaheed,

Having so many changes in a single commit is not really reviewable now or in 
the future. Commits should be minimal so that people in the future who 
examine the history can make sense of it. The commit message for that commit 
says

 Re-introduce the missing databases.

but in fact it appears to be a complete re-write in a single commit.

Please extract meaningful changes into separate commits. For example, the 
change to

 find-modules/Qt5Ruleset.py

must correspond to only a part of the rest of the commit. Please extract 
that into a commit. Then consider any other changes in the big commit and 
extract small meaningful commits and repeat. 

When reviewing commits the reader should have only one context in mind. For 
example "ok, this commit is changing the API of rulesets" or "ok, this 
commit is introducing a noop so enable silencing warnings".

 Usually that context for the commit should be in the commit message!

Thanks,

Steve.