Re: PyKF5 bindings generator improvements out for review.

Stephen Kelly <[email protected]>
Newsgroups gmane.comp.kde.devel.bindings
Message-ID <[email protected]>
Shaheed Haque wrote:

> Rewrite? It think its more a case of forking making things diverge (if you
> look, a lot of the changes are formatting, name changes and comments,
> though I accept that does make for a lot of noise). I have tried VERY hard
> to keep the good changes form both sides...and yes, there ARE a reasonable
> number of actual changes too.
> 
> Anyway, I was under the impression a squashed single commit was preferred,
> but I can look to pull things out again. I would prefer to work the
> reviews via github's Pull Requests, is that still OK?

Yep, sounds good to me!

Thanks,

Steve.
lmpx.com only provides a reader for public news (NNTP) servers. It is not affiliated with the servers or forums shown here and is not responsible for the content of articles, which is written by their respective authors.