Re: PyKF5 bindings generator improvements out for review.

I also put out https://github.com/ShaheedHaque/extra-cmake-modules/pull/3.


On 29 January 2017 at 21:09, Shaheed Haque <[email protected]> wrote:

> OK, let's start small: https://github.com/ShaheedHaque/extra-cmake-
> modules/pull/2.
>
> Please review...
>
> On 29 January 2017 at 17:12, Stephen Kelly <[email protected]> wrote:
>
>> Shaheed Haque wrote:
>>
>> > Rewrite? It think its more a case of forking making things diverge (if
>> you
>> > look, a lot of the changes are formatting, name changes and comments,
>> > though I accept that does make for a lot of noise). I have tried VERY
>> hard
>> > to keep the good changes form both sides...and yes, there ARE a
>> reasonable
>> > number of actual changes too.
>> >
>> > Anyway, I was under the impression a squashed single commit was
>> preferred,
>> > but I can look to pull things out again. I would prefer to work the
>> > reviews via github's Pull Requests, is that still OK?
>>
>> Yep, sounds good to me!
>>
>> Thanks,
>>
>> Steve.
>>
>>
>