Re: PyKF5 bindings generator improvements out for review.

Shaheed Haque wrote:

> Steve,
> 
> PRs 2 through 7, at
> https://github.com/ShaheedHaque/extra-cmake-modules/pulls are now the
> complete set of the changes required to bring the mainstream'd fork up to
> par with mine.
> 
> I'll be continuing the bringup of the automatic QMap/QList/etc and array
> stuff; hopefully you'll have a chance to review the above.
> 
> Thanks, Shaheed
> 

Hi Shaheed,

The pull requests are not really necessary. It's enough to put a branch on 
your clone and tell me the name of it (and you can rebase the branch as much 
as you like).

I've pushed parts of what is in your pull requests to master. Please take a 
look at the recent commits. Notice that I split the commits up further to do 
one thing per commit and not contain noise. Please compare with your commits 
and see that my commits are smaller, and the commit message says what it 
does, and there are more of them. 

Simple, short and noiseless commits are easy to review, so please see if you 
can follow suit there.

Also note that I changed the tests you wrote because there is nothing 
'obscure' about visibility or pure virtual functions.

Please rebase the rest of your work onto master and see if you can extract 
any other small commits from it.

Thanks,

Steve.