[dolphin] [Bug 501435] The icon for "Open Terminal Here" is always Konsole regardless of user's actual default terminal emulator

https://bugs.kde.org/show_bug.cgi?id=501435

Méven <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/syst |https://invent.kde.org/syst
                   |em/dolphin/-/commit/eaaeb1b |em/dolphin/-/commit/62b12e9
                   |7629cc3c59933101d24dd0c2c67 |c307372100a7e70176abd45f662
                   |ef1276                      |8d1b2b

--- Comment #7 from Méven <[email protected]> ---
Git commit 62b12e9c307372100a7e70176abd45f6628d1b2b by Méven Car, on behalf of
Bharadwaj Raju.
Committed on 07/08/2026 at 10:17.
Pushed by meven into branch 'master'.

Fix icon lookup for "Open Terminal" actions

Using KDesktopFile to read the desktop entry from a desktop name (i.e.
"org.something.terminalapp.desktop") is incorrect; KDesktopFile is for
making modifications to a desktop entry, and hence does not even try to
find existing desktop entries in the correct places.
See src/core/kdesktopfile.cpp in the KConfig source code, particularly
the call to KConfigPrivate::changeFileName.

The result of this is that ultimately it does not find desktop entries
located in /usr/share/applications or the Flatpak equivalent, and hence
fails to locate icons.

Instead, use KService::serviceByStorageId.

Steps to reproduce:
  1. Install a terminal app like WezTerm
  2. Set it as default in System Settings > Default Applications
  3. Right click inside a folder in Dolphin
  4. Observe the lack of an icon
Related: bug 436178

M  +3    -3    src/dolphinmainwindow.cpp

https://invent.kde.org/system/dolphin/-/commit/62b12e9c307372100a7e70176abd45f6628d1b2b

-- 
You are receiving this mail because:
You are watching all bug changes.