[krusader] [Bug 524076] After adding the same bookmark multiple times, only one instance is displayed and later Krusader ends abruptly

https://bugs.kde.org/show_bug.cgi?id=524076

Toni Asensi Esteve <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
      Latest Commit|                            |https://invent.kde.org/util
                   |                            |ities/krusader/-/commit/f06
                   |                            |b8f0f969d45093129387fcb45be
                   |                            |847ef832f9
             Status|REPORTED                    |RESOLVED

--- Comment #4 from Toni Asensi Esteve <[email protected]> ---
Git commit f06b8f0f969d45093129387fcb45be847ef832f9 by Toni Asensi Esteve.
Committed on 16/08/2026 at 22:14.
Pushed by asensi into branch 'master'.

BookMan: Solve 'After adding the same bookmark multiple times, only one
instance is displayed and later Krusader ends abruptly'

Solve a mismatch between the `krbookmarks.xml` format (which allows
multiple bookmarks to use the same display name) and KActionCollection
(which uses string names in order to identify pointers).

Now, the `importFromFileBookmark` function checks the `seenBookmarks`
QSet. If an action name has already been claimed during the current
parsing pass, it automatically generates a unique internal suffix
(e.g. `_2`, `_3`).

This allows Krusader to safely allocate distinct KrBookmark pointers
for every entry in the XML file, preserving user data and avoiding
use-after-free and double-free problems.

FIXED: [ 524076 ] After adding the same bookmark multiple times, only one
instance is displayed and later Krusader ends abruptly

Revision: https://invent.kde.org/utilities/krusader/-/merge_requests/193

M  +30   -12   app/BookMan/krbookmarkhandler.cpp

https://invent.kde.org/utilities/krusader/-/commit/f06b8f0f969d45093129387fcb45be847ef832f9

-- 
You are receiving this mail because:
You are watching all bug changes.