Re: KDE review request: KDominate
Nicolas Fella <[email protected]> Sat, 28 Feb 2026 16:05:09 +0100
| Newsgroups | gmane.comp.kde.devel.core |
|---|---|
| Message-ID | <[email protected]> |
This is a multi-part message in MIME format. --------------01GjM4AnsNlYrhPACIoy1uNw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable On 2/28/26 3:47 PM, Harald Sitter wrote: >> Albert Vaca Cintora<[email protected]> hat am 28.02.2026 14:57 CET g= eschrieben: >> >> >> On Sat, Feb 28, 2026 at 1:19=E2=80=AFPM Harald Sitter<[email protected]> w= rote: >>> One could argue going through review while not being a KDE repo (i.e. = in repo-metadata) makes no sense since you can't follow the process and ma= rk it in-review >>> =20 >>> https://develop.kde.org/docs/getting-started/add-project/review/#pro= cess >>> =20 >>> I guess the answer is that it needs moving. >> Oh, I thought moving would happen *after* it got reviewed and accepted. For some reason I can't explain that is a common misconception as of=20 recently. The last few review requests *all* made that mistake. Nobody=20 really questioned it until now, but it's not how it's supposed to work. >> About the instructions you linked, I did miss the item about updating r= epo-metadata, but actually I'm not sure I understand it. It says: >> >>> =C2=A0Make a merge request to repo-metadata to set the lifecycle key = to lifecycle: in-review >> But it doesn't mention which file within=C2=A0repo-metadata I should cr= eate/update. > You'll get a file as part of moving to a proper shared namespace. For th= at you need to file a sysadmin request. > > I guess the docs need a bit more detail for the case when a project star= ts "in KDE". Something like > > - create project in your namespace > - push some initial code > - file sysadmin request to have it moved to some shared namespace > - this results in lifecycle:playground > - then follow the review process to move on from there > > CCing Thiago in the hopes that I don't have to update the docs :D > > HS --------------01GjM4AnsNlYrhPACIoy1uNw Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable <!DOCTYPE html> <html> <head> <meta http-equiv=3D"Content-Type" content=3D"text/html; charset=3DUTF-= 8"> </head> <body> <div class=3D"moz-cite-prefix">On 2/28/26 3:47 PM, Harald Sitter wrote:<br> </div> <blockquote type=3D"cite" cite=3D"mid:[email protected]"> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre">Albert Vaca Cintora <a clas= s=3D"moz-txt-link-rfc2396E" href=3D"mailto:[email protected]"><alber= [email protected]></a> hat am 28.02.2026 14:57 CET geschrieben: On Sat, Feb 28, 2026 at 1:19=E2=80=AFPM Harald Sitter <a class=3D"moz-txt-= link-rfc2396E" href=3D"mailto:[email protected]"><[email protected]></a> w= rote: </pre> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre">One could argue going thr= ough review while not being a KDE repo (i.e. in repo-metadata) makes no se= nse since you can't follow the process and mark it in-review =20 <a class=3D"moz-txt-link-freetext" href=3D"https://develop.kde.org/docs/g= etting-started/add-project/review/#process">https://develop.kde.org/docs/g= etting-started/add-project/review/#process</a> =20 I guess the answer is that it needs moving. </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre"> Oh, I thought moving would happen *after* it got reviewed and accepted.</p= re> </blockquote> </blockquote> <p>For some reason I can't explain that is a common misconception as of recently. The last few review requests *all* made that mistake. Nobody really questioned it until now, but it's not how it's supposed to work.</p> <p><span style=3D"white-space: pre-wrap"> </span></p> <blockquote type=3D"cite" cite=3D"mid:[email protected]"> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre"> About the instructions you linked, I did miss the item about updating repo= -metadata, but actually I'm not sure I understand it. It says: </pre> <blockquote type=3D"cite"> <pre wrap=3D"" class=3D"moz-quote-pre">=C2=A0Make a merge reques= t to repo-metadata to set the lifecycle key to lifecycle: in-review </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre"> But it doesn't mention which file within=C2=A0repo-metadata I should creat= e/update. </pre> </blockquote> <pre wrap=3D"" class=3D"moz-quote-pre"> You'll get a file as part of moving to a proper shared namespace. For that= you need to file a sysadmin request. I guess the docs need a bit more detail for the case when a project starts= "in KDE". Something like - create project in your namespace - push some initial code - file sysadmin request to have it moved to some shared namespace - this results in lifecycle:playground - then follow the review process to move on from there CCing Thiago in the hopes that I don't have to update the docs :D HS </pre> </blockquote> </body> </html> --------------01GjM4AnsNlYrhPACIoy1uNw--