RE: qt4 win32-msvc2005 manifests

Hi Christian,

I just tried the current Qt version (4.1.0) with the latest patch from
Qt/Win Free provided by you.
Thanks a lot for embedding the manifests now.

I have 2 minor improvements:
In qmake\generators\win32\msvc_nmake.cpp you may replace

project->variables() [ "QMAKE_POST_LINK" ] += "mt.exe /manifest
$(DESTDIR_TARGET).manifest /outputresource:$(DESTDIR_TARGET);#2";

by 

if (project->variables()[ "QMAKE_APP_FLAG" ].isEmpty())
	project->variables() [ "QMAKE_POST_LINK" ] += "mt.exe /manifest
$(DESTDIR_TARGET).manifest /outputresource:$(DESTDIR_TARGET);#2";
else
	project->variables() [ "QMAKE_POST_LINK" ] += "mt.exe /manifest
$(DESTDIR_TARGET).manifest /outputresource:$(DESTDIR_TARGET);#1";

since application manifests should be embedded as a resource with ID equal
to 1 (at least the msdn docs state that).


Similarily, in qmake\Makefile.win32-msvc2005 you may replace

mt.exe /manifest $(DESTDIR_TARGET).manifest
/outputresource:$(DESTDIR_TARGET);#2

by

mt.exe /manifest $(DESTDIR_TARGET).manifest
/outputresource:$(DESTDIR_TARGET);#1

since qmake itself is also an application.

Best regards,
Marco

_______________________________________________
kde-cygwin mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/kde-cygwin