[devel] Re: kdenonbeta/kdedebian/kalternatives/src

On Monday 18 October 2004 14:43, Mario Bensi wrote:
> CVS commit by bensi:
>
> add all icons on all buttons
>
>
>   M +3 -0      addalternatives.cpp   1.12
>   M +2 -0      addslaves.cpp   1.5
>   M +1 -0      kalternatives.cpp   1.20
>
>
> --- kdenonbeta/kdedebian/kalternatives/src/addalternatives.cpp  #1.11:1.12
> @@ -64,4 +64,7 @@ QWidget(kalt,0, WDestructiveClose | WTyp
>
>          addAlternativesUi->m_bBrowse->setGuiItem(KGuiItem( "" , "fileopen"
> )); +        addAlternativesUi->m_bOk->setGuiItem(KGuiItem( "&Ok" , "ok"
> )); +        addAlternativesUi->m_bCancel->setGuiItem(KGuiItem( "&Cancel" ,
> "cancel" )); +       
> addAlternativesUi->m_bAddSlave->setGuiItem(KGuiItem(i18n("&Add Slave"),
> "edit_add"));
>
>          resize( 435, 185 );
>
> --- kdenonbeta/kdedebian/kalternatives/src/addslaves.cpp  #1.4:1.5
> @@ -53,4 +53,6 @@ QWidget(addAlternatives, 0, WDestructive
>
>          addSlavesUi->m_bBrowse->setGuiItem(KGuiItem( "" , "fileopen" ));
> +        addSlavesUi->m_bOk->setGuiItem(KGuiItem( "&Ok" , "ok" ));
> +        addSlavesUi->m_bCancel->setGuiItem(KGuiItem( "&Cancel" , "cancel
<snip>
> +                prop->bClose->setGuiItem(KGuiItem( "&Close" , "close" ));
>                  prop->show();
>          }
Mario, there exists standard gui items for this, see 
kdelibs/kdeui/kstdguiitem.h

Benjamin, one could add tests which detects hand craftings of 
kstdguiitems(it's also mentioned in the docs I sent, IIRC).


Cheers,

		Frans