D29077: Fix MacOS build for missing bundle
patrick j pereira <[email protected]>
| Newsgroups | gmane.comp.kde.devel.education |
|---|---|
| Message-ID | <5392d2f5bd97426c108554ed6e2f6f3e__2421.98040229908$1587731852$gmane$org@localhost.localdomain> |
patrickelectric added a comment.
@apol doing so results in
CMake Error at src/app/CMakeLists.txt:87 (install):
install TARGETS given no BUNDLE DESTINATION for MACOSX_BUNDLE executable
target "minuet".
I took a look in `KDEInstallDirs.cmake:711` and I can see that is sets the bundle with:
709 │ # on the Mac support an extra install directory for application bundles
710 │ if(APPLE)
711 │ set(KDE_INSTALL_TARGETS_DEFAULT_ARGS ${KDE_INSTALL_TARGETS_DEFAULT_ARGS}
712 │ BUNDLE DESTINATION "${BUNDLE_INSTALL_DIR}" )
713 │ set(KF5_INSTALL_TARGETS_DEFAULT_ARGS ${KF5_INSTALL_TARGETS_DEFAULT_ARGS}
714 │ BUNDLE DESTINATION "${BUNDLE_INSTALL_DIR}" )
715 │ endif()
I did a simple test and APPLE is true in my macbook, so I don't know why and what is happening.
Patch update to reflect what I'm running here.
REPOSITORY
R163 Minuet
REVISION DETAIL
https://phabricator.kde.org/D29077
To: patrickelectric, sandroandrade
Cc: apol, kde-edu, narvaez