D29549: Updates to SkyPoint to improve positions

Jasem Mutlaq <[email protected]> Sat, 9 May 2020 18:04:23 +0000

Newsgroups	gmane.comp.kde.devel.education
Message-ID	<a769f66f6534a9d83d920754f4656e8a__13441.9740339339$1589047494$gmane$org@localhost.localdomain>

mutlaqja added a comment.


  Thank you Chris, this is a much needed fix! The SkyPointTest was crashing though due to checkBendLight function which then tries to get the SkyMapComposite pointer which is null. So I disabled useRelativistic option that would lead to this. Furthermore, two tests fail:
  
  FAIL!  : TestSkyPoint::compareSkyPointLibNova(near S Pole) 'fabs(ra1 - ra2) < err' returned FALSE. (Ra 226.738, 226.739 error   -2.0)
  
    Loc: [/home/jasem/Projects/kstars/Tests/skyobjects/test_skypoint.cpp(510)]
  
  QDEBUG : TestSkyPoint::compareSkyPointLibNova(near S Pole) ln expected  pos1 226.738, -85.1112 pos2 226.739, -85.1112 errors   -2.2,   -0.0 secs
  FAIL!  : TestSkyPoint::compareSkyPointLibNova(near S Pole) 'fabs(ra1 - ra2) < err' returned FALSE. (Ra 226.738, 226.739 error   -2.2)
  
    Loc: [/home/jasem/Projects/kstars/Tests/skyobjects/test_skypoint.cpp(510)]

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D29549

To: chrisrowland, mutlaqja
Cc: kde-edu, narvaez, apol