D29836: Code refactoring unifying capture initialization for new sequences and continuing of sequences

Chris Rowland <[email protected]> Sun, 31 May 2020 21:53:23 +0000

Newsgroups	gmane.comp.kde.devel.education
Message-ID	<a2c219606646e5aa7a8b12fbabcf775e__45460.0960759976$1590962031$gmane$org@localhost.localdomain>

chrisrowland added a comment.


  I'm sorry but I don't think I am qualified to review a refactor of the 
  capture module because I do not have enough understanding of the capture 
  process to be able to contribute.
  
  I see no benefit in my nit picking about the code style.
  
  I should also point out that I've asked Jasem to revert the meridian 
  flip changes I made.  It looks as if there have been too many side 
  effects in other parts of the system and in other mount control systems 
  to make the changes viable for production code.  I don't know if 
  reverting that will affect this.
  
  Chris

REPOSITORY
  R321 KStars

REVISION DETAIL
  https://phabricator.kde.org/D29836

To: wreissenberger, mutlaqja, chrisrowland, TallFurryMan, murveit
Cc: yurchor, kde-edu, narvaez, apol