D29840: enumeration memory games multiple_dataset

Johnny Jazeix <[email protected]> Tue, 2 Jun 2020 07:40:35 +0000

Newsgroups	gmane.comp.kde.devel.education
Message-ID	<a3e9ce1836e0d713f7e73849162fa370__34644.1290735797$1591083665$gmane$org@localhost.localdomain>

jjazeix added inline comments.

INLINE COMMENTS

> Data.qml:29
> +
> +    property var url: "qrc:/gcompris/src/activities/memory-enumerate/resource/"
> +

string

> MemoryCommon.qml:70
>              property int playerScore: playerScore.text
> -            property var dataset: activity.dataset
> +            property var levels: activity.datasetLoader.data !=  0 ? activity.datasetLoader.data : activity.dataset
>              property alias containerModel: containerModel

is there a reason to check a dataset against 0?

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D29840

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, AkshayCHD, amankumargupta, echarruau
Cc: kde-edu, narvaez, apol