D29840: enumeration memory games multiple_dataset

emmanuel charruau <[email protected]> Wed, 10 Jun 2020 08:17:51 +0000

Newsgroups	gmane.comp.kde.devel.education
Message-ID	<379505820c7fd95e4e33159de394adce__18876.4746346109$1591777104$gmane$org@localhost.localdomain>

echarruau added a comment.


  Hi,
  Maybe because you use a diff that you commit? No idea on my side but
  could you ask Timothée or Johnny to kbao why? What is sure is that I
  don't see it.
  
  Le mar. 9 juin 2020 à 11:45, Deepak Kumar
  <[email protected]> a écrit :
  
  > dekumar added a comment. View Revision
  > 
  > In D29840#674920 <https://phabricator.kde.org/D29840#674920>, @echarruau wrote:
  > 
  > Changes are ok.
  >  I would still need to see the process test table where you will document how you do the tests to be sure that you are not breaking any of the other memory activity.
  > 
  > I have fixed that in this commit https://phabricator.kde.org/R2:8c7cdc63d0fff90f1b22fc3afa66ff7625bc03f5
  >  Not getting why it's not updated over here.
  > 
  > REPOSITORY
  >  R2 <https://phabricator.kde.org/source/gcompris/> GCompris
  > 
  > REVISION DETAIL
  >  https://phabricator.kde.org/D29840
  > 
  > To: dekumar, GCompris: Improvements, jjazeix, timotheegiet, AkshayCHD, amankumargupta, echarruau
  >  Cc: kde-edu, narvaez, apol

REPOSITORY
  R2 GCompris

REVISION DETAIL
  https://phabricator.kde.org/D29840

To: dekumar, #gcompris_improvements, jjazeix, timotheegiet, AkshayCHD, amankumargupta, echarruau
Cc: kde-edu, narvaez, apol