D20831: Add fullscreen mode to kmahjongg

Albert Astals Cid <[email protected]> Thu, 25 Apr 2019 21:23:22 +0000

Newsgroups	gmane.comp.kde.devel.games
Message-ID	<[email protected]>

aacid added inline comments.

INLINE COMMENTS

> kmahjongg.cpp:173
>  
> +    QAction * fullscreen = actionCollection()->addAction(QStringLiteral("view_fullscreen"));
> +    fullscreen->setText(i18n("Fullscreen"));

use KStandardAction::fullScreen  ? https://api.kde.org/frameworks/kconfigwidgets/html/namespaceKStandardAction.html#a0e30d17570d5b886e97b1f2cf34ef900

that way you don't have to set the text (which is wrong) nor the icon yourself

REPOSITORY
  R403 KMahjongg

REVISION DETAIL
  https://phabricator.kde.org/D20831

To: krippendorf, #kde_games
Cc: aacid, kde-games-devel, krippendorf